886474 - Stop using Ctrl + ] [ to match brackets in source editor

Status: RESOLVED FIXED

(DevTools :: Source Editor, defect)

Description

[Girish Sharma [:Optimizer]]

When you are in Debugger or Style Editor, Ctrl + ] and Ctrl + [ are used to match brackets, due to which we cannot use those shortcuts to switch tools as we want in bug 879219.

After discussing on IRC with Victor and Mihai, we came up with a consensus to change the source-editor's shortcuts. The most favorable shortcut is Ctrl + M and Ctrl + Shift + M. But if we are not happy with that, we can do Ctrl + Alt + ] [ .

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

+1 Ctrl+Alt+[/]

Comment 2

[Girish Sharma [:Optimizer]]

Oh, I forgot to mention why Ctrl + M is favorable: because its used by Sublime Text

Comment 3

[Mihai Sucan [:msucan]]

Ctrl+Alt+[/]

Comment 4

[Girish Sharma [:Optimizer]]

Attachment: patch v0.1

Comment 5

[Mihai Sucan [:msucan]]

Comment on attachment 767925 [details] [diff] [review]
patch v0.1

Thanks! r+ with green try push.

Comment 6

[Girish Sharma [:Optimizer]]

green try : https://tbpl.mozilla.org/?tree=Try&rev=b044fa5da599

Comment 7

[Girish Sharma [:Optimizer]]

Landed : https://hg.mozilla.org/integration/fx-team/rev/4cdab5388392

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

Trying to use Ctrl+Alt+[/] doesn't seem to have any effect, but Ctrl+Shift+[/] works. Inspecting the patch confirms that. The problem with that however, is that on OS X at least, this shortcut conflicts with the shortcut to switch tabs, which makes bracket matching only work in a detached toolbox.

Let's either use the agreed upon shortcut or use a different one on OS X.

Comment 9

[Girish Sharma [:Optimizer]]

Whoops. Fix coming.

Comment 10

[Girish Sharma [:Optimizer]]

Attachment: correct patch

Correct patch. going through try

Comment 11

[Girish Sharma [:Optimizer]]

try seems to be green https://tbpl.mozilla.org/?tree=Try&rev=01196ec712d5

Comment 12

[Girish Sharma [:Optimizer]]

Backed out the previous patch : https://hg.mozilla.org/integration/fx-team/rev/70a26ecaed5c
and landed again : https://hg.mozilla.org/integration/fx-team/rev/d90d62737979

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4cdab5388392

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d90d62737979