Closed Bug 886518 Opened 11 years ago Closed 11 years ago

In debug/valgrind builds, purge the skia typeface cache on gfxplatform shutdown

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bjacob, Assigned: bjacob)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch purge skia typeface cache leak (obsolete) — Splinter Review
This should fix the font leaks reported in bug 874768 comment 2. Verifying.

Note that this also turns on resetting Cairo static data in MOZ_VALGRIND builds, in addition to DEBUG builds.

Had to do the skia purging before the Cairo resetting because of Skia's dependency on Cairo (namely, the Skia typeface cache referencing Cairo typefaces).
Attachment #766883 - Flags: review?(jmuizelaar)
Attachment #766883 - Flags: review?(gwright)
Comment on attachment 766883 [details] [diff] [review]
purge skia typeface cache leak

Review of attachment 766883 [details] [diff] [review]:
-----------------------------------------------------------------

r+, but I'm assuming you meant to switch to intentionally leaking the cairo fonts if not in debug/valgrind?
Attachment #766883 - Flags: review?(gwright) → review+
Comment on attachment 766883 [details] [diff] [review]
purge skia typeface cache leak

Let's use the correct interface instead.
Attachment #766883 - Flags: review?(jmuizelaar) → review-
This fixes much of the remaining leaks, see bug 874768 comment 3.

@ Jeff: patch coming calling SkGraphics::Term.

@ George: my patch shouldn't make us leak anything that we didn't leak before. If it does, please r-.
Attached file purge skia typeface cache (obsolete) —
Now calling the right thing.
Attachment #766883 - Attachment is obsolete: true
Attachment #767386 - Flags: review?(jmuizelaar)
Landed on gfx branch. Marking as fixed here, but still worth reviewing for the future big landing.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment on attachment 767386 [details]
purge skia typeface cache

This is still exporting SkTypefaceCache.h
Attachment #767386 - Flags: review?(jmuizelaar) → review-
Attachment #767386 - Attachment is obsolete: true
Attachment #769145 - Flags: review?
Attachment #769145 - Flags: review? → review?(jmuizelaar)
Attachment #769145 - Flags: review?(jmuizelaar) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: