Add basic wrappers around 'adb forward' and 'adb remount' to dmADB

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: ahal, Assigned: ahal)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
We need to run some commands like 'adb remount' and 'adb forward' when setting up b2g unittests. DevicemanagerADB should make it easier for us to do so.
(Assignee)

Comment 1

6 years ago
Created attachment 767298 [details] [diff] [review]
Patch 1.0 - add remount, forward and devices methods to dmADB
Attachment #767298 - Flags: review?(wlachance)
Comment on attachment 767298 [details] [diff] [review]
Patch 1.0 - add remount, forward and devices methods to dmADB

Review of attachment 767298 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good except for some minor documentation issues. r+ with those addressed.

::: mozdevice/mozdevice/devicemanagerADB.py
@@ +157,5 @@
>          return None
>  
> +    def forward(self, local, remote):
> +        """
> +        Forward socket connections, forward specs are one of:

This line should just say "forward socket connection.". Put "Forward specs are one of:" two lines down.

@@ +168,5 @@
> +        """
> +        return self._checkCmd(['forward', local, remote])
> +
> +    def remount(self):
> +        "Remounts the /system partition on the device read-write"

Please end this docstring with a period.

@@ +172,5 @@
> +        "Remounts the /system partition on the device read-write"
> +        return self._checkCmd(['remount'])
> +
> +    def devices(self):
> +        "Return a list of connected devices as (serial, status) tuples"

Please end this docstring with a period.
Attachment #767298 - Flags: review?(wlachance) → review+
(Assignee)

Comment 3

6 years ago
https://github.com/mozilla/mozbase/commit/e5dfee56018ca57d06b67b8a32e1883f8f238b7c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.