Closed Bug 886608 Opened 12 years ago Closed 12 years ago

Add basic wrappers around 'adb forward' and 'adb remount' to dmADB

Categories

(Testing :: Mozbase, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ahal, Assigned: ahal)

Details

Attachments

(1 file)

We need to run some commands like 'adb remount' and 'adb forward' when setting up b2g unittests. DevicemanagerADB should make it easier for us to do so.
Comment on attachment 767298 [details] [diff] [review] Patch 1.0 - add remount, forward and devices methods to dmADB Review of attachment 767298 [details] [diff] [review]: ----------------------------------------------------------------- Looks good except for some minor documentation issues. r+ with those addressed. ::: mozdevice/mozdevice/devicemanagerADB.py @@ +157,5 @@ > return None > > + def forward(self, local, remote): > + """ > + Forward socket connections, forward specs are one of: This line should just say "forward socket connection.". Put "Forward specs are one of:" two lines down. @@ +168,5 @@ > + """ > + return self._checkCmd(['forward', local, remote]) > + > + def remount(self): > + "Remounts the /system partition on the device read-write" Please end this docstring with a period. @@ +172,5 @@ > + "Remounts the /system partition on the device read-write" > + return self._checkCmd(['remount']) > + > + def devices(self): > + "Return a list of connected devices as (serial, status) tuples" Please end this docstring with a period.
Attachment #767298 - Flags: review?(wlachance) → review+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: