88661 - Need "Remove all data" button in the "Form Manager" window

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect)

Description

[Henrik Gemal]

There's missing a "Remove all data" button from the "From Manager" window. It's 
the window that gets shown when pressing the "View stored Form Data".

build 20010630

Comment 1

[Stephen P. Morse]

There's no separate facility for doing this only in the form manager.  But there 
is a facility for removing all form-manager and password manager data.  It's in 
the password manager menu.

The reason for this facility is to permit the user who has forgotten the master 
password to start all over.  Otherwise he would have to discard the entire 
profile but this allows him to discard only that part of the profile that is 
under control of the master password.

Why do you want a separate facility for deleting just the form-manager data?

(See also bug 88543).

Comment 2

[doctor__j]

morse: Did you mean "Task -> Privacy and Security -> Password Manager -> Clear
Sensitive Information"?  (Phew... what a long menu...)

Comment 3

[Henrik Gemal]

a normal user, including me, have no idea that password manager data and form 
manager data has something to do with each other.

Therefore we need a clear form data button in the Form Manager.

The Clear Form Data button shoul only clear the form data. Not password data.

Comment 4

[Stephen P. Morse]

Yes, that's what I meant.

Comment 5

[Stephen P. Morse]

Attachment: adding remove-all button to form-manager dialog

Comment 6

[Stephen P. Morse]

Attached patch to include the remove-all button.  However will this be vetoed 
because UI is frozen?

cc'ing vishy and blake for r and sr in case they want to get this in now.

Comment 7

[Viswanath Ramachandran]

Adding German for UE input. 

Comment 8

[Stephen P. Morse]

German, please comment here.  Vishy is holding up his review until he hears from 
you.

Background info.  Form manager is the only one of the privacy dialogs that 
doesn't provide a remove-all capability.  There is a remove-all menu item under 
password manager (which also removes form-manager data) but that's doesn't 
replace the need for a form-manager-only remove all in the form manager dialog.

Comment 9

[Viswanath Ramachandran]

since we now have clarification that controlled UI changes are acceptable, 
r=vishy. 

I do have one doubt. Should the style= attributes in XUL be moved to css? Blake 
can comment on that as part of sr=. 

Comment 10

[Viswanath Ramachandran]

Blake could you look at sr= this so that we can get it off the list? thanks! 
Vishy

Comment 11

[Blake Ross]

+ while (menuPopup.firstChild != menuPopup.lastChild) {

Why not just check to see if there's only one item left?

Instead of setting the label to "", why not remove it?

The style should be in a content stylesheet, but there's a bug on doing all that
work at once, so I guess this is okay for now.

Comment 12

[Stephen P. Morse]

Attachment: revised patch to satisfy reviewers comments

Comment 13

[Blake Ross]

The |values| variable seems to be unused?

Also, I'm a little confused.

var menuPopup = menuList.firstChild;

Then you get menuPopup.firstChild.  Why is it menuList.firstChild.firstChild...?

Comment 14

[Blake Ross]

Oh I see. firstChild is menupopup, then that has childNodes.  Why remove all but
the last item for each...?  

Also, Jatin, can you suggest wording here? The current wording seems to suggest
that all the data will be cleared, not just the data for the panel.

Comment 15

[Stephen P. Morse]

Attachment: revised patch to satisfy reviewers next comment

Comment 16

[Stephen P. Morse]

> Why remove all but the last item for each...?  

The editable menulists for form-manager have been designed to always contain 
exactly one empty entry.  This is the entry that the user types in to add 
addtional values.

> Also, Jatan, can you suggest wording here? The current wording seems to
> suggest that all the data will be cleared, not just the data for the panel.

That is correct, all the data will be cleared, not just the data for the panel.

Comment 17

[Blake Ross]

sr=blake

Comment 18

[Stephen P. Morse]

Checked in a couple of days ago but I forgot to close this out as such.

Comment 19

[Blake Ross]

Need to reopen:

* When you Remove Saved Data, the concatenations panel often gets wiped out.
* This button should not be directly under the tree, but horizontally aligned
with the OK/Cancel buttons (but to the left).

Comment 20

[Stephen P. Morse]

> When you Remove Saved Data, the concatenations panel often gets wiped out.

That's the correct behavior.  The initial value of the concatenation panel in a 
fresh profile is an empty display.

> This button should not be directly under the tree, but horizontally aligned
> with the OK/Cancel buttons (but to the left).

Why?  In any case, this bug called for the remove-all function to be implemented 
and it has now been implemented.  Therefore this bug has been fixed.  If you 
want to complain about the screen placement of this new button, that's a new bug 
and should be done in a new report.

Comment 21

[Henrik Gemal]

Blake: Did you open some new bugs on the items you described?
If you do please Cc me on them...

But this bug is fixed