Closed
Bug 886611
Opened 11 years ago
Closed 11 years ago
Rename SetupCairoStrokeHitGeometry and SetupCairoStrokeGeometry to make their purposes clearer. (particularly to clarify that the "Hit" one isn't just for hit-testing)
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(2 files)
4.18 KB,
patch
|
longsonr
:
review+
|
Details | Diff | Splinter Review |
5.91 KB,
patch
|
longsonr
:
review+
|
Details | Diff | Splinter Review |
Paraphrasing Robert Longson from bug 886548 comment #1, regarding the difference between SetupCairoStrokeGeometry and SetupCairoStrokeHitGeometry: > nsSVGUtils::SetupCairoStrokeGeometry is only called in > nsSVGPathGeometryFrame::GetBBoxContribution it skips the SetDash there as > whether dash styles can't affect the bounding box, at least not with the > approximation based code we currently have. He suggested we rename as follows: > s/SetupCairoStrokeGeometry/SetupCairoStrokeBBoxGeometry/ and > s/SetupCairoStrokeHitGeometry/SetupCairoStrokeGeometry/ perhaps. I think that renaming makes sense.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #766998 -
Flags: review?
Assignee | ||
Updated•11 years ago
|
Attachment #766998 -
Flags: review? → review?(longsonr)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #766999 -
Flags: review?(longsonr)
Assignee | ||
Updated•11 years ago
|
Summary: Rename SetupCairoStrokeHitGeometry and SetupCairoStrokeGeometry to make their purposes clearer. (and that the "Hit" one isn't just for hit-testing) → Rename SetupCairoStrokeHitGeometry and SetupCairoStrokeGeometry to make their purposes clearer. (particularly to clarify that the "Hit" one isn't just for hit-testing)
Updated•11 years ago
|
Attachment #766998 -
Flags: review?(longsonr) → review+
Updated•11 years ago
|
Attachment #766999 -
Flags: review?(longsonr) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/584d089e7167 https://hg.mozilla.org/integration/mozilla-inbound/rev/7d0990045b34
Flags: in-testsuite-
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/584d089e7167 https://hg.mozilla.org/mozilla-central/rev/7d0990045b34
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•