HTMLCanvasElement.h should not include nsLayoutUtils.h

NEW
Unassigned

Status

()

P5
normal
5 years ago
4 days ago

People

(Reporter: dbaron, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I touched nsLayoutUtils.h and wondered why everything in dom/bindings was rebuilding.  The reason is that dom/bindings files include HTMLCanvasElement.h (something khuey said he'd look into fixing), and that includes nsLayoutUtils.h (unnecessarily).
Created attachment 766991 [details] [diff] [review]
HTMLCanvasElement.h (which is included in dom/bindings) should not include nsLayoutUtils.h
Attachment #766991 - Flags: review?(khuey)
Comment on attachment 766991 [details] [diff] [review]
HTMLCanvasElement.h (which is included in dom/bindings) should not include nsLayoutUtils.h

Review of attachment 766991 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, although this doesn't actually fix the problem that you saw.
Attachment #766991 - Flags: review?(khuey) → review+
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/0bb9f1eec70b because I couldn't tell whether this or bug 858937 was the cause of the sPagePrintTimer warnings-as-errors bustage of https://tbpl.mozilla.org/php/getParsedLog.php?id=24554210&tree=Mozilla-Inbound
Probably not worth digging into this further, for now at least.
Assignee: dbaron → nobody
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.
Priority: -- → P5
No assignee, updating the status.
Status: ASSIGNED → NEW
No assignee, updating the status.
You need to log in before you can comment on or make changes to this bug.