Closed
Bug 886635
Opened 12 years ago
Closed 4 years ago
HTMLCanvasElement.h should not include nsLayoutUtils.h
Categories
(Core :: Graphics: Canvas2D, defect, P5)
Core
Graphics: Canvas2D
Tracking
()
RESOLVED
DUPLICATE
of bug 928900
People
(Reporter: dbaron, Unassigned)
Details
Attachments
(1 file)
I touched nsLayoutUtils.h and wondered why everything in dom/bindings was rebuilding. The reason is that dom/bindings files include HTMLCanvasElement.h (something khuey said he'd look into fixing), and that includes nsLayoutUtils.h (unnecessarily).
|
Reporter | |
Comment 1•12 years ago
|
||
Attachment #766991 -
Flags: review?(khuey)
Comment on attachment 766991 [details] [diff] [review]
HTMLCanvasElement.h (which is included in dom/bindings) should not include nsLayoutUtils.h
Review of attachment 766991 [details] [diff] [review]:
-----------------------------------------------------------------
r=me, although this doesn't actually fix the problem that you saw.
Attachment #766991 -
Flags: review?(khuey) → review+
|
|
Reporter | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/0bb9f1eec70b because I couldn't tell whether this or bug 858937 was the cause of the sPagePrintTimer warnings-as-errors bustage of https://tbpl.mozilla.org/php/getParsedLog.php?id=24554210&tree=Mozilla-Inbound
|
|
Reporter | |
Comment 5•12 years ago
|
||
Probably not worth digging into this further, for now at least.
Assignee: dbaron → nobody
|
||
Comment 6•7 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046
Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.
If you have questions, please contact :mdaly.
Priority: -- → P5
|
||
Comment 8•7 years ago
|
||
No assignee, updating the status.
|
||
Updated•5 years ago
|
Component: DOM: Core & HTML → Canvas: 2D
|
||
Updated•4 years ago
|
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•