886656 - GTest linking fails with disable-metro 'module machine type 'x64' conflicts with target machine type 'X86'

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benoit Girard (:BenWa)]

msvcprtd.lib(MSVCP90D.dll) : fatal error LNK1112: module machine type 'x64' conflicts with target machine type 'X86'

https://tbpl.mozilla.org/php/getParsedLog.php?id=24546949&tree=Mozilla-Aurora#error1

Looks like somewhere the architecture type is getting mixed up. This error is happening on aurora where we disabled metro. Currently on central metro is enabled which disables gtest. For now gtest should be disabled completely on windows until we can fix these problems. Also there is no value in running GTest on aurora right now since we're still building up unit tests.

Comment 1

[Benoit Girard (:BenWa)]

Attachment: Disable GTest on windows

Comment 2

[Phil Ringnalda (:philor)]

Comment on attachment 767024 [details] [diff] [review]
Disable GTest on windows

r=philor (oddly, nobody ever complains about that like they should), a=test-only, shipit!

Comment 3

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/50de8c1763e2

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 767024 [details] [diff] [review]
Disable GTest on windows

Review of attachment 767024 [details] [diff] [review]:
-----------------------------------------------------------------

Just in case anyone was worried about bypassing build peer review. I hope this gets fixed soon!

Comment 5

[Benoit Girard (:BenWa)]

Comment on attachment 767024 [details] [diff] [review]
Disable GTest on windows

Inbound is closed.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f69065d3d763

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f69065d3d763