886657 - AudioBufferSourceNode starts as soon as it's connected

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This is a pretty bad bug. As soon as the AudioBufferSourceNode's buffer is created and it's connected to the destination, we start playing even if start() hasn't been called yet!

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/376fe12f4de4

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Backed out (along with bug 886657 which I don't have access to) due to frequent OSX 10.7 mochitest-1 failures.
https://hg.mozilla.org/integration/mozilla-inbound/rev/b99a907d9d97

https://tbpl.mozilla.org/php/getParsedLog.php?id=24575534&tree=Mozilla-Inbound

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This patch appears to not have been guilty:
https://tbpl.mozilla.org/?tree=Try&rev=c3ef1a360feb

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec8ceaf4b03a

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ec8ceaf4b03a

Comment 7

[(no longer active)]

roc, can you please backport the landed patch to 24?

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 767028 [details] [diff] [review]
fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): None
User impact if declined: WebAudio bug
Testing completed (on m-c, etc.): landed for a while
Risk to taking this patch (and alternatives if risky): very low risk
String or IDL/UUID changes made by this patch: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2f1fcbcf7ee3

Comment 10

[u279076]

Robert, can you please advise QA how to test this?

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

There's an automated test, no QA needed.

Comment 12

[u279076]

Thanks Robert.