Closed Bug 886657 Opened 6 years ago Closed 6 years ago
Buffer Source Node starts as soon as it's connected
This is a pretty bad bug. As soon as the AudioBufferSourceNode's buffer is created and it's connected to the destination, we start playing even if start() hasn't been called yet!
Backed out (along with bug 886657 which I don't have access to) due to frequent OSX 10.7 mochitest-1 failures. https://hg.mozilla.org/integration/mozilla-inbound/rev/b99a907d9d97 https://tbpl.mozilla.org/php/getParsedLog.php?id=24575534&tree=Mozilla-Inbound
This patch appears to not have been guilty: https://tbpl.mozilla.org/?tree=Try&rev=c3ef1a360feb
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
roc, can you please backport the landed patch to 24?
Comment on attachment 767028 [details] [diff] [review] fix [Approval Request Comment] Bug caused by (feature/regressing bug #): None User impact if declined: WebAudio bug Testing completed (on m-c, etc.): landed for a while Risk to taking this patch (and alternatives if risky): very low risk String or IDL/UUID changes made by this patch: none
Attachment #767028 - Flags: approval-mozilla-aurora?
Attachment #767028 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
6 years ago
Robert, can you please advise QA how to test this?
There's an automated test, no QA needed.
Flags: needinfo?(roc) → in-testsuite+
You need to log in before you can comment on or make changes to this bug.