886715 - [MMS] [Regression] After changing language all strings should be in new language

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Borja Salguero [:borjasalguero]]

Attachment: Issue

Changing the language is not working properly for the composer-header. Check attachment.

Comment 1

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

Comment 2

[Borja Salguero [:borjasalguero]]

This is a regression, leo+?

Comment 3

[Borja Salguero [:borjasalguero]]

Comment on attachment 767080 [details]
Pull Request

Corey is going to take a look because this is happening in other places as well.

Comment 4

[Borja Salguero [:borjasalguero]]

We have detected that this is happening in more places, so Corey is going to take a look. Dietrich, this is a regression, leo+?

Comment 5

[Corey Frang [:gnarf]]

There are many strings, generally the header in the messages view, the download mms strings, etc are all not properly localized when the language is changed while the app is running. I'm sure there are more as well

Comment 6

[Corey Frang [:gnarf]]

I'd like to argue for this not being QE3 - and also not being leo+

Are there many people who will be switching language with open applications and expecting everything to change immediately?  The app fixes itself after changing pages anyway.

Visibility seems pretty low, and complexity of the fix is fairly high (because it affects much more than just the header)

Renominating.

Comment 7

[Corey Frang [:gnarf]]

Comment on attachment 767080 [details]
Pull Request

Only solves one of the problem cases, and there are also better ways to solve.

Comment 8

[Tony Chung [:tchung]]

leo-, as most users will not change languages often, and as comment 6 notes that it can be fixed within itself after changing pages within the app.   renom if you feel otherwise with a comment.

Comment 9

[Fabien Cazenave [:kaze]]

This might be solved by the patch I’ve done for bug 898992:
https://github.com/mozilla-b2g/gaia/pull/11304

Corey, please ask me to review your patch if you work on this — or feel free to re-assign this bug to me.

Comment 10

[Corey Frang [:gnarf]]

(In reply to Fabien Cazenave [:kaze] from comment #9)
> This might be solved by the patch I’ve done for bug 898992:
> https://github.com/mozilla-b2g/gaia/pull/11304
> 
> Corey, please ask me to review your patch if you work on this — or feel free
> to re-assign this bug to me.

I'm using that work to fix this.  The problem is we do a lot of mozL10n.get(string) and stuff innerText with it.  Were we should be instead using .localize or .translate and setting the right l10n properties on the elements.  I'm just doing a giant audit of all our uses of l10n for this ticket to make sure we get all of the places.

Comment 11

[Corey Frang [:gnarf]]

If you want to take a look at it - I've been pushing up my progress pretty much every major .js file -  https://github.com/gnarf/gaia/compare/886715

Comment 12

[Corey Frang [:gnarf]]

Attachment: pull request on github

Looking for feedback from kaze/rick, and review from julien on this pull.

Any other input also welcome - thanks!

Comment 13

[Julien Wajsberg [:julienw]]

Comment on attachment 789138 [details] [review]
pull request on github

made a first pass but I have not looked at the test yet, neither tried it in the device. I keep this for tomorrow.

Reviewint this I've seen a lot of dialogs whose markup is inserted using JS whereas we could have it in index.html instead.

Comment 14

[Julien Wajsberg [:julienw]]

Comment on attachment 789138 [details] [review]
pull request on github

patch works well to me, but still some questions have to be answered regarding some functionality to be moved to l10n.js

Comment 15

[Jack Liu]

Dear mozilla, marked koi? to make sure these issues ok for v1.2

Comment 16

[Julien Wajsberg [:julienw]]

Comment on attachment 789138 [details] [review]
pull request on github

r=me with the latest nit

check that the tests still pass locally before merging !

Comment 17

[Corey Frang [:gnarf]]

master: https://github.com/mozilla-b2g/gaia/commit/359b24a12724f1f8227e4d5b99a60bc3050846af

Comment 18

[Fabien Cazenave [:kaze]]

FTR, this patch introduces a new user-facing string (“view-attachment”) and should add it to the *.properties file. Filing a follow-up.

Comment 19

[Julien Wajsberg [:julienw]]

Yeah, we eventually renamed it to "view-attachment-other".