Various cleanups in faulty.lib

RESOLVED FIXED in mozilla25

Status

()

Core
mozglue
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla25
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 767092 [details] [diff] [review]
Add and use a MemoryRange class and helper functions for page alignment in faulty.lib

This should make the code less error-prone.
Attachment #767092 - Flags: review?(nfroyd)
Comment on attachment 767092 [details] [diff] [review]
Add and use a MemoryRange class and helper functions for page alignment in faulty.lib

Review of attachment 767092 [details] [diff] [review]:
-----------------------------------------------------------------

r/rs=me
Attachment #767092 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 767655 [details] [diff] [review]
Move a szip.cpp MOZ_ASSERT to a safer place

outBuf.Resize changes the address of outBuf, and header points to the old location.
Attachment #767655 - Flags: review?(nfroyd)
Attachment #767655 - Flags: review?(nfroyd) → review+
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e307319bf2e4
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae6f3b0bc23d

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/e307319bf2e4
https://hg.mozilla.org/mozilla-central/rev/ae6f3b0bc23d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.