886742 - Clicking Forgot pin does nothing if bango logout is an error page.

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P2)

Description

[[e-mail]]

Attachment: Console.log

STR: 

 * Once you have set a pin (webpay not bango), try to buy an app
 * Instead of entering the pin click "Forgot your pin?"

What happens:

 * User gets stuck on loading screen
 * The only way out is to close the trusted-ui.

What should happen:

 * User can reset their pin.

Comment 1

[[e-mail]]

This appears to be caused by http://mozilla.test.bango.org/mozpayments/logout/ being a 500.

We should however work out a better way to handle this because the current reponse causes logout to hang because the bango.logout() in the deferreds here: https://github.com/mozilla/webpay/blob/master/media/js/pay/pay.js#L126 doesn't resolve.

Seems also that with dataType = 'script' the response is eaten, whereas if the dataType is 'text' it does at least expose the error.

Comment 2

[[e-mail]]

The bango logout url is fixed now but we need to work out what we can do to show an error in the event of this happening again.

The biggest problem is when the 500 happened it was just an html page and as a result no errors arose as a result of the failed request.

Comment 3

[Andy McKay]

Adding to this milestone because its a P2.

Comment 4

[[e-mail]]

r? https://github.com/mozilla/webpay/pull/223

Comment 5

[[e-mail]]

https://github.com/mozilla/webpay/commit/082de6665060dbbb17f781d6790f8665de994660