886767 - [MMS] Disable grouping functionality when receiving a MMS (temporarily) and keep it for sending

Status: VERIFIED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Beatriz Rodríguez [:brg]]

we want to keep grouping functionality enable when sending MMS to multiple recipients but as it is hard to figure out the MSISDN of the user when it is not stored in the SIM card, we need to disable this functionality for receiving MMS.

Comment 1

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

Comment 2

[Gene Lian (I already quit Mozilla)]

Hi Vicamo,

We just achieved a conclusion today with all the PMs and Gaia folks. We want to disable the MMS grouping for receiving for v1.1. That is, we only keep the sender in the thread. Note that we still want to keep the grouping for sending.

Comment 3

[Gene Lian (I already quit Mozilla)]

Note: this bug need to be landed before Thursday morning.

Comment 4

[Gene Lian (I already quit Mozilla)]

Hi Beatriz and Borja,

One quick question: do we want to disable the MMS grouping for all kinds of SIMs, or only for the SIM whose MSISDN is not available?

Sorry I didn't follow that bit in the meeting. Hoping to clarify. Thanks!

Comment 5

[Beatriz Rodríguez [:brg]]

We want to disable MMS grouping for all kind of SIM cards.

Comment 6

[Gene Lian (I already quit Mozilla)]

Got it. Thanks Beatriz!

Comment 7

[Gene Lian (I already quit Mozilla)]

Attachment: Patch, V1.1

Comment 8

[Gene Lian (I already quit Mozilla)]

Attachment: Patch, V1.2

Fix a nit in the comment.

Comment 9

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 767262 [details] [diff] [review]
Patch, V1.2

Review of attachment 767262 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobilemessage/src/ril/MobileMessageDatabaseService.js
@@ +1139,1 @@
>        aMessage.receiver = self;

Have you also try the SMS part?

Comment 10

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Sorry, no need. My bad.

(In reply to Chia-hung Tai [:ctai :ctai_mozilla :cht] from comment #9)
> Comment on attachment 767262 [details] [diff] [review]
> Patch, V1.2
> 
> Review of attachment 767262 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/mobilemessage/src/ril/MobileMessageDatabaseService.js
> @@ +1139,1 @@
> >        aMessage.receiver = self;
> 
> Have you also try the SMS part?

Comment 11

[Gene Lian (I already quit Mozilla)]

Attachment: Patch, V1.3

Refine some comments and debug messages.

Comment 12

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 767569 [details] [diff] [review]
Patch, V1.3

Review of attachment 767569 [details] [diff] [review]:
-----------------------------------------------------------------

Good job!

Comment 13

[Wayne Chang [:wchang]]

Triage - leo+ per discussion agreement between partners.

Comment 14

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/projects/birch/rev/a87696202500
https://hg.mozilla.org/releases/mozilla-b2g18/rev/855297ec671e

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a87696202500

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/855297ec671e

Comment 17

[isabelrios]

Now a reply to a group message creates a new thread. The grouping functionality when receiving a reply has been disabled.
Verified with unagi 06/27 build.
Gecko-914243b
Gaia-477e572