886809 - Import SIM contacts fails if contact has no number

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Florin Strugariu [:Bebe]]

Attachment: Logcat for the test

STR:
1. Add a contact on a SIM card that has ONLY a name 
2. Insert the sim in a Unaghi with:
Gecko  http://hg.mozilla.org/mozilla-central/rev/76820c6dff7b
Gaia  427e0100826c677cee1341c4d83793321f16bb5f
BuildID 20130624031223
Version 24.0a1

3. Open the contacts app
4. Tap settings 
5. Tap import from Sim card
6. Wait


Expected:
6. A contact is imported with only the name 

Actual:
6. The Reading from SIM card.... message is present and the app is stuck there.
If we kill the app no contact is imported

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Gregor, is this familiar to you, or should I dive into the gaia code?

Comment 2

[Florin Strugariu [:Bebe]]

If I try to import a contact that has only a phone number but no name the import works

I think it has something to do with Bug 847741  but I'm not sure

Comment 3

[Gregor Wagner [:gwagner]]

Is there anything in logcat? It's hard to tell if this is a contacts API problem or a RIL related problem.

Comment 4

[Zac C (:zac)]

To Gregor/Francisco/devs, what is the definition of a valid contact? Should it have both name and phonenumber or is just one of each enough?

My Android phone for example won't let me create a SIM contact without a number. but just a number and no name is acceptable too.

Is there validation in the Gaia import contact code?

Comment 5

[Jason Smith [:jsmith]]

I'm going to guess this is probably a regression, right? If so, I'm guessing this is a blocker by it's definition.

Comment 6

[Zac C (:zac)]

In our automation it is working fine on v1-train and failing against master (build noted in comment #0) so yes it is a regression.

Comment 7

[Reuben Morais [:reuben]]

(In reply to Zac C (:zac) from comment #4)
> To Gregor/Francisco/devs, what is the definition of a valid contact? Should
> it have both name and phonenumber or is just one of each enough?

As far as the Contacts API is concerned, it doesn't have to have any properties. (i.e. new mozContact({}) works and creates a valid contact).

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

RIL issue, taking this.

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 1: Patch

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Part 2: xpcshell tests.

Comment 11

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 768179 [details] [diff] [review]
Part 1: Patch

Review of attachment 768179 [details] [diff] [review]:
-----------------------------------------------------------------

Great!

Comment 12

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

http://hg.mozilla.org/projects/birch/rev/d6fc9a9d76cc
http://hg.mozilla.org/projects/birch/rev/d8beb5ae6053

Comment 13

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d6fc9a9d76cc
https://hg.mozilla.org/mozilla-central/rev/d8beb5ae6053

Comment 14

[Andrew Overholt [:overholt]]

Removing koi? since this is in gecko 25 which is < 26 which will be the basis for Firefox OS 1.2.