886824 - Introduce shell target for l20n.js

Status: RESOLVED FIXED

(L20n :: JS Library, defect)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

We currently have to targets - html and gaia.

For performance testing I'd like to add a shell target. This will make it possible to launch l20n from v8 or jsshell.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: patch

Comment 2

[Staś Małolepszy :stas]

Comment on attachment 767232 [details] [diff] [review]
patch

Review of attachment 767232 [details] [diff] [review]:
-----------------------------------------------------------------

::: bindings/l20n/shell.js
@@ +2,5 @@
> +  'use strict';
> +
> +  var L20n = require('../l20n');
> +  var Promise = require('./promise').Promise;
> +  var io = require('./platform/io');

Why do you need promise and io here, without it exposing them on L20n?

Comment 3

[Staś Małolepszy :stas]

Attachment: Patch 2

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

https://github.com/l20n/l20n.js/commit/4210be148c3d9936c0b8e1386c91c3815292d5e9