toolkit/components/places/moz.build has a space in a filename

RESOLVED FIXED in mozilla25

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mshal, Assigned: mshal)

Tracking

Trunk
mozilla25
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The toolkit/components/places/moz.build file has 'nsITaggingService.idl ', in XPIDL_SOURCES. The extraneous space in the filename should be removed.
(Assignee)

Comment 1

5 years ago
Created attachment 767233 [details] [diff] [review]
Remove extraneous space from moz.build file
Attachment #767233 - Flags: review?(joey)

Updated

5 years ago
Attachment #767233 - Flags: review?(joey) → review+
(Assignee)

Comment 2

5 years ago
inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/0e057e794ada
https://hg.mozilla.org/mozilla-central/rev/0e057e794ada
Assignee: nobody → mshal
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Should we make the moz.build reader error on leading or trailing spaces?

Comment 5

5 years ago
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4)
> Should we make the moz.build reader error on leading or trailing spaces?

There's a whole layer of validation we could be performing in emitter.py that we currently don't. Add this to the long list of things we'll likely do some day.
You need to log in before you can comment on or make changes to this bug.