886827 - toolkit/components/places/moz.build has a space in a filename

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michael Shal [:mshal]]

The toolkit/components/places/moz.build file has 'nsITaggingService.idl ', in XPIDL_SOURCES. The extraneous space in the filename should be removed.

Comment 1

[Michael Shal [:mshal]]

Attachment: Remove extraneous space from moz.build file

Comment 2

[Michael Shal [:mshal]]

inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/0e057e794ada

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0e057e794ada

Comment 4

[(not currently active) Ted Mielczarek]

Should we make the moz.build reader error on leading or trailing spaces?

Comment 5

[Gregory Szorc [:gps]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4)
> Should we make the moz.build reader error on leading or trailing spaces?

There's a whole layer of validation we could be performing in emitter.py that we currently don't. Add this to the long list of things we'll likely do some day.