88685 - Remove --disable-libpr0n and USE_IMG2 ifdefs

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[cls]

Comment 1

[cls]

Attachment: Remove --disable-pr0n and USE_IMG2 from unix & win32 builds.

Comment 2

[cls]

Requesting mac help to remove this cruft.

Comment 3

[saari (gone)]

This is easy on mac, just tell me when it is safe to try.

Comment 4

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 5

[Stephen Walker]

*** Bug 131046 has been marked as a duplicate of this bug. ***

Comment 6

[Stephen Walker]

cls/saari: any hope in getting all the patches & finally removing this anytime 
soon?

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: content/ part of USE_IMG2 removal

removes USE_IMG2 from content/
also removes a variable that was only used if USE_IMG2 was not defined

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: layout/ part

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

there are also USE_IMG2 uses in gfx/ which I'm too lazy to fix now

Comment 10

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 98292 [details] [diff] [review]
content/ part of USE_IMG2 removal

r=caillon

Comment 11

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 98293 [details] [diff] [review]
layout/ part

r=caillon

Comment 12

[tor]

Comment on attachment 98292 [details] [diff] [review]
content/ part of USE_IMG2 removal

sr=tor

Comment 13

[tor]

Comment on attachment 98293 [details] [diff] [review]
layout/ part

sr=tor

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 98292 [details] [diff] [review]
content/ part of USE_IMG2 removal

checked in

Comment 15

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 98293 [details] [diff] [review]
layout/ part

checked in

Comment 16

[Christian :Biesinger (don't email me, ping me on IRC)]

taking bug

Comment 17

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: remove USE_IMG2 ifdefs in gfx/

Comment 18

[Stephen Walker]

Comment on attachment 105875 [details] [diff] [review]
remove USE_IMG2 ifdefs in gfx/

r=walk84

Comment 19

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 105875 [details] [diff] [review]
remove USE_IMG2 ifdefs in gfx/

bz, could you super-review? easy to do, just a bit of ifdef removal.

Comment 20

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 105875 [details] [diff] [review]
remove USE_IMG2 ifdefs in gfx/

The rendering context api has the IMG2 DrawImage calls and the other set as
well... are both used?	Should both be present?  Can one be eliminated?

In addition, I would prefer that _someone_ (either the r= or the sr=) who
reviews this patch know something about gfx.  I know I don't, really, and I
suspect neither does walk84.  I would not feel comfortable putting my sr on
this patch as-is.

Comment 21

[ArronM (:paper)]

http://lxr.mozilla.org/seamonkey/search?string=%5C%3EDrawImage%5C%28
reveals these are being used:
714   NS_IMETHOD DrawImage(nsIImage *aImage, nscoord aX, nscoord aY,
715                        nscoord aWidth, nscoord aHeight) = 0; 

721   NS_IMETHOD DrawImage(nsIImage *aImage, const nsRect& aRect) = 0;

and if you include the throbber sample (which I wouldn't), this one's being used:

705   NS_IMETHOD DrawImage(nsIImage *aImage, nscoord aX, nscoord aY) = 0;


_looks_like_ DrawImage(nsIImage *aImage, const nsRect& aSRect, const nsRect&
aDRect) is not being used

Comment 22

[Christian :Biesinger (don't email me, ping me on IRC)]

these last two functions that you mentioned are indeed not used, not on linux at
least - my tree compiles with them commented out.

I'll look ta the other things later.

Comment 23

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: ok, let's remove some unused functions

this patch removes some unused DrawImage and DrawTile functions, and related
stuff

Comment 24

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: as last patch, but also remove unneeded #include

same as the last "remove unused functions" patch, but here I also remove some
#include "nsIImage.h" and a "class nsIImage;" forward declaration.

Comment 25

[Christian :Biesinger (don't email me, ping me on IRC)]

cc'ing some people who might be interested in the last patch here (which is
basically a cleanup of nsIRenderingContext)

Comment 26

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 109771 [details] [diff] [review]
as last patch, but also remove unneeded #include

I'll review this

Comment 27

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Looks good, just a couple of questions:
1) Why haven't you removed the actual USE_IMG2 #ifdefs in nsIRenderingContext?
2) Please fix the throbber test.
Other than that --- thank you, thank you, thank you!

Comment 28

[Robert O'Callahan (:roc) (email my personal email if necessary)]

*** Bug 186158 has been marked as a duplicate of this bug. ***

Comment 29

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 105875 [details] [diff] [review]
remove USE_IMG2 ifdefs in gfx/

sr=roc+moz

Comment 30

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 109771 [details] [diff] [review]
as last patch, but also remove unneeded #include

r+sr=roc+moz after biesi pointed out that the throbber code is in #if 0

Strictly speaking I'm not a GFX peer but I do know GFX and for this trivial
stuff, it doesn't matter.

Comment 31

[Christian :Biesinger (don't email me, ping me on IRC)]

ok, the last two non-obsolete patches here are checked in now.


leaving open for the final removal of USE_IMG2 from the build system

Comment 32

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: Final USE_IMG2 removal

(marking the checked in patches obsolete)

Comment 33

[hacker formerly known as [e-mail]]

Comment on attachment 109898 [details] [diff] [review]
Final USE_IMG2 removal

r=cls

Comment 34

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in