Closed Bug 886859 Opened 12 years ago Closed 11 years ago

constrain the toolbar icon size

Categories

(Firefox Graveyard :: SocialAPI, defect)

23 Branch
x86
macOS
defect
Not set
normal

Tracking

(firefox24 affected, firefox25 affected)

RESOLVED WONTFIX
Tracking Status
firefox24 --- affected
firefox25 --- affected

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Details

Attachments

(1 file)

noticed via some of our tests, the icon is not sized properly to the button, larger icons will visibly overflow.
Attached patch fix icon sizeSplinter Review
Assignee: nobody → mixedpuppy
Attachment #771003 - Flags: review?(jaws)
Comment on attachment 771003 [details] [diff] [review] fix icon size Review of attachment 771003 [details] [diff] [review]: ----------------------------------------------------------------- Yeah, we should use list-style-image and -moz-image-region to properly clip the image if it is too large.
Attachment #771003 - Flags: review?(jaws)
In Firefox 22 the toolbar icons are too big. Please reduce the size to have them like firefox 21 icons.
This issue is resolved with the new toolbar buttons, and since we're removing the old toolbar button in bug 935640 I see no reason to fix.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: