add a delete codepath, to remove a project from the database

RESOLVED FIXED

Status

Webmaker
Thimble
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: pomax, Assigned: pomax)

Tracking

Details

(Whiteboard: s=2013w26 p=1 u=dev)

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Part of https://bugzilla.mozilla.org/show_bug.cgi?id=882389, this ticket is about adding an app.delete route for projects so that they can be removed from the database. This is one of the modular functions necessary to effect proper project unpublishing.
(Assignee)

Updated

5 years ago
Blocks: 882389
(Assignee)

Updated

5 years ago
Summary: add a /delete route, to remove a project from the database → add a delete codepage, to remove a project from the database
(Assignee)

Updated

5 years ago
Summary: add a delete codepage, to remove a project from the database → add a delete codepath, to remove a project from the database
(Assignee)

Comment 1

5 years ago
Created attachment 767391 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/157

open to improvements on the dev-route for testing deletions; the rest of the code can tie into how we want to do deletion queue handling.
Attachment #767391 - Flags: review?(jon)

Comment 2

5 years ago
Comment on attachment 767391 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/157

r+ with nits noted in the pull request
Attachment #767391 - Flags: review?(jon) → review+
(Assignee)

Comment 3

5 years ago
Comment on attachment 767391 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/157

renamed .delete to .destroy, to stay closer to the sequelize API, and added a special dedicated var for enabling the deletion route. Also updated the README (oh my!)
Attachment #767391 - Flags: review+ → review?
(Assignee)

Updated

5 years ago
Attachment #767391 - Flags: review? → review?(jon)

Updated

5 years ago
Attachment #767391 - Flags: review?(jon) → review+

Comment 4

5 years ago
Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org

https://github.com/mozilla/thimble.webmaker.org/commit/e4e746ce1c78bee59731e1b2dafa0fe610c2ba62
Merge pull request #157 from Pomax/bug886860

Bug886860 - adding a delete route for projects
(Assignee)

Comment 5

5 years ago
landed. this code path can now be hooked into.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.