88692 - image/tiff keeps opening windows until mozilla is killed

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Christopher Blizzard (:blizzard)]

Build is a 0.9.2 release build.  If you visit the url (an image/tiff image) it
will keep opening new windows.

Comment 1

[Bill Nottingham]

FWIW, it's actually not a *valid* tiff file. It's a mangled faces file
masquerading as a tiff file. (This crashes xloadimage when spawned from plugger
in NS4. Wheeeeee.) I just pointend mozilla at it to See What Happens.

Comment 2

[doctor__j]

Is that a trick?

Comment 3

[Doug Turner (:dougt)]

pavlov, save us.

Comment 4

[James Cooper]

Confirm on 0.9.2 (sort of) Win2k as well.

Initial description not exactly true. It'll keep going until you kill the newest
rougue window. Dunno if Moz is supposed to render TIFFs, but I don't think it
should blow up on them. I'm attaching a TIFF from NASA that I figure should be
valid.

Comment 5

[James Cooper]

Attachment: Image (TIFF) of the north part of the moon. Makes Mozilla behave poorly.

Comment 6

[Scott MacGregor]

looks like nsBrowserInstance incorrectly registers mozilla as being able to
render image/tiff. So we end up creating a browser window to load the image/tiff
but then gecko says it can't render it so we end up creating another browser
window all because of:




  { "Browser Content Handler",
    NS_BROWSERCONTENTHANDLER_CID,
    NS_CONTENT_HANDLER_CONTRACTID_PREFIX"image/tiff", 
    nsBrowserContentHandlerConstructor 
  } 

Comment 7

[Christopher Blizzard (:blizzard)]

Attachment: ...in patch format

Comment 8

[Christopher Blizzard (:blizzard)]

Interesting.  My build here is popping up a dialog asking to save it.

However, we should remove this handler anyway, right?

Comment 9

[Stuart Parmenter]

no clue.  r=pavlov

Comment 10

[Christopher Blizzard (:blizzard)]

mscott?  Can you super-review?  Also, do you agree with my comment?

Comment 11

[Scott MacGregor]

I didn't understand your comment. If you remove this handler then you should see
the helper app dialog come up. 

We should remove the tiff handler registration since we don't display image/tiff.

sr=mscott

Comment 12

[Christopher Blizzard (:blizzard)]

I checked this in.

Comment 13

[Jacob Kjome]

I just thought I'd let people know that the testcase that James Cooper posted
(moon image) does not generate scrollbars when loaded within the Quicktime 5.02
plugin even though the Image is larger than the current window displying it.  I
reported that as bug 90162.

Jake

Comment 14

[av (gone)]

I applied the patch to my two-day old Windows trunk build and still experiencing 
the original problem. Should I do something extra or we should reopen this one?

Comment 15

[Scott MacGregor]

av, did you delete your components.reg file? Since this changes a component's
registration, you need to delete that file for it to take effect.

Comment 16

[av (gone)]

OK, this helps, thanks.

Comment 17

[Stuart Parmenter]

*** Bug 91616 has been marked as a duplicate of this bug. ***

Comment 18

[Stuart Parmenter]

*** Bug 96257 has been marked as a duplicate of this bug. ***