mozillians.org: localizability issues

VERIFIED FIXED in 2013-06-27

Status

VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: flod, Unassigned)

Tracking

(Blocks: 1 bug)

other
2013-06-27

Details

(Whiteboard: [kb=1027307] )

(Reporter)

Description

5 years ago
These strings appear in English even if my locale should be complete (all strings in messages.po are localized). Where possible I added a reference to the code.


https://github.com/mozilla/mozillians/blob/master/apps/users/templates/registration/register.html#L33
Our community directory is for Mozillians who are 13 and older. We take safety issues very seriously, especially with minors. If you are under 13, please don't create an account.


(Not sure if it's the right piece of code, but the warning is displayed on top of the page, reddish background.)
https://github.com/mozilla/mozillians/blob/master/apps/common/middleware.py#L16
You must be vouched to continue.


https://github.com/mozilla/mozillians/blob/master/apps/phonebook/templates/phonebook/home.html#L65
Passionate Mozillians you can meet for work, play or a cup of coffee.


Can't find this one, it should be in groups/forms.py as well
Sort: (label)


https://github.com/mozilla/mozillians/blob/master/apps/groups/forms.py#L14
Group Name A-Z
Most members
Fewest members


https://github.com/mozilla/mozillians/blob/master/apps/groups/templates/groups/index.html#L12
Sort (button)


https://github.com/mozilla/mozillians/blob/master/apps/groups/templates/groups/group.html#L15
Curated group:


Editing profile, values of "Visible to:" are in English (Mozillians/Public)


Invite someone
Recipient, Message are in English.


This should work but it's still displayed in English.
https://github.com/mozilla/mozillians/blob/master/apps/phonebook/templates/phonebook/invited.html#L11
"has been invited to Mozillians. They'll receive an email with instructions on how to join. You can invite another Mozillian if you like."


Text of the invite email is in English.
https://github.com/flodolo/mozillians/blob/master/apps/phonebook/templates/phonebook/invite_email.txt
(Reporter)

Updated

5 years ago
Summary: Mozillians: localizability issues → mozillians.org: localizability issues

Comment 1

5 years ago
PR submitted here: https://github.com/mozilla/mozillians/pull/532
(Reporter)

Comment 2

5 years ago
Hi Julia,
from a quick look at the PR I don't these are addressed. Can you confirm?

1) "Sort:" 
This label is displayed over the "sort form", but I can't find it anywhere.

2) "Curated group:" (heading)
https://github.com/mozilla/mozillians/blob/master/apps/groups/templates/groups/group.html#L15

4) Editing profile, values of "Visible to:" are in English (Mozillians/Public)

5) When inviting someone, the labels "Recipient" and "Message" are in English.

6) "X has been invited to Mozillians. They'll receive an email with instructions on how to join. You can invite another Mozillian if you like."
https://github.com/mozilla/mozillians/blob/master/apps/phonebook/templates/phonebook/invited.html#L11

7) Text of the invite email is in English.
https://github.com/flodolo/mozillians/blob/master/apps/phonebook/templates/phonebook/invite_email.txt

Comment 3

5 years ago
Hi Francesco!

Below are some answers to your questions + more fixes. Please let me know if you have any other questions or need more clarification.

1) This should be resolved here:https://github.com/juliaelman/mozillians/commit/26e65b9615b7cc7d8d5aa59015416aeaec3c8258#L3R12

2) This syntax *should* make this string translatable and do not see where an error might occur. Going to pass this one to the other Mozillian team members to take a second look.

4) I posed a question in my PR on whether or not the team wanted to translate this. Waiting for an answer from the team before moving forward. https://github.com/mozilla/mozillians/pull/532

5/7) Also wrote notes in the PR to reference this: https://github.com/mozilla/mozillians/pull/532

6) The block *is* wrapped with the {% trans %} syntax, so this might possibly be missing a translation. Making a note of this in the PR.
(Reporter)

Comment 4

5 years ago
> 1) This should be resolved
> here:https://github.com/juliaelman/mozillians/commit/
> 26e65b9615b7cc7d8d5aa59015416aeaec3c8258#L3R12

That should be the button. Is the same label used for the text before before the list box?
 
> 6) The block *is* wrapped with the {% trans %} syntax, so this might
> possibly be missing a translation. Making a note of this in the PR.

No idea, the string is translated for sure (line 203). My doubt is with the starting variable that messes things up
http://viewvc.svn.mozilla.org/vc/projects/l10n-misc/trunk/mozillians/locales/it/LC_MESSAGES/messages.po?revision=117245&view=markup
Whiteboard: [kb=1027307]
Target Milestone: --- → 2013-06-27
(Reporter)

Comment 6

5 years ago
messages.po for Italian has been updated a few hours ago (after the merge) but the stage still hasn't changed. Can you check if something's wrong? 

I guess we should also close this bug and open follow-ups for specific problems.
That's actually normal, there's no mechanism on the server to svn up periodically for localization so it only happens when we do pushes. I'll do one soon since there are some patches that need to go up too.
I'm going to resolve this fixed and you can refile bugs for individual issues from this one.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
I'm going to give :flod he honor of marking this bug verified (comment 8).
Flags: needinfo?(francesco.lodolo)
(Reporter)

Comment 10

5 years ago
Yep, verified and bugs already filed for individual issues still valid.
Status: RESOLVED → VERIFIED
Flags: needinfo?(francesco.lodolo)
Fantastic .. thanks flod
You need to log in before you can comment on or make changes to this bug.