887185 - Plugins test assumes click-to-play is enabled by default (aka permanent orange | TEST-UNEXPECTED-FAIL | test_plugins.js | 4 == 20

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Mark Banner (:standard8)]

Attachment: The fix

This occurred following bug 886423 - not all gecko based applications are ready to enable click to play just yet (e.g. bug 814168).

test_plugins.js was changed assuming that click_to_play is defaulting to true.

Therefore the attached patch ensures that plugins.click_to_play is set to true when running the test. This is similar to other tests in the code base that set click_to_play to true before they are run.

Comment 1

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 767675 [details] [diff] [review]
The fix

Review of attachment 767675 [details] [diff] [review]:
-----------------------------------------------------------------

This should be fine - we do this all over the place.
I'm not a toolkit peer, so technically I can't r+ this, but I'm sure you could get the go-ahead if you ping someone like bsmedberg on irc.

Comment 2

[Benjamin Smedberg]

Hrm. I was planning on removing the click_to_play pref altogether, as soon as I was sure that we wouldn't need to revert anything. What's the ETA for bug 814168? I could leave only the bits of the click_to_play pref that affect the addon manager UI, since the rest is now probably a no-op.

Comment 3

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/730aabb3f40a

Comment 4

[Mark Banner (:standard8)]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> Hrm. I was planning on removing the click_to_play pref altogether, as soon
> as I was sure that we wouldn't need to revert anything. What's the ETA for
> bug 814168? I could leave only the bits of the click_to_play pref that
> affect the addon manager UI, since the rest is now probably a no-op.

I haven't looked at it in detail, but given it has a patch, I'm hoping we could land it this cycle.

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/730aabb3f40a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/79c1d8a1d805

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Bad idea. Backed out.
https://hg.mozilla.org/releases/mozilla-beta/rev/42ad033a758a