Closed Bug 887186 Opened 12 years ago Closed 12 years ago

Center Thimble makes by default

Categories

(Webmaker Graveyard :: Thimble, defect)

Product:
Webmaker Graveyard
Component:
Thimble
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: laura, Unassigned)

Details

All mozteach makes were centered originally, during transfer Scott told me forcing the centering using a style in the body tag was bad practice, but it was the only way I could get the pages centered for some reason. Now none of the makes are centered, the fixed position feedback links are over top of the content, and I'm not sure how I should center all these pages. Would be nice if thimble makes were centered by default anyway :)
It is defining css right on element names that should be avoided. Class names are much better. centered is fine but doing it on the body tag was causing the details bar to also get css styling. We fixed it yesterday. The details bar cannot be changed anymore as it is no longer living in the thimble page (after a republish) it is now contained inside iframes. Also the previous fix I gave you for the centered issue kept things centered so it should still be centered. I tried not to break that. So if your pages are not centered any more we should fix that. ping me with any questions and I am happy to help.
yeah, nothing is centered anymore, but everything has the previous fix in it. Ping me when you're caffeinated and we can figure it out. (here's one of the makes for reference: https://mozteach.makes.org/thimble/spectrogram-for-interactive-video )
you can add a class to the body, i.e. <body class="centered"> and then using the rule ".centered { width: ...; margin: 0 auto; }" to make it all centered again.
to wit, we're also now serving the thimble pages in its own iframe, so that the CSS rules no longer override any of our webmaker details bar and make data. You could use a body { } rule again if you really wanted, but using a class would be the better way to do it (and would show people that classes apply to everything =)
Yeah, we worked out that all this needs is a republish, we get the iframe fix, and everything is centered.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.