887210 - cannot activate the provider (sidebar shows connect error)

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[edA-qa mort-ora-y]

Activation of a social provider results in a sidebar which shows a "connection" error. This is possibly related to bug 887206, perhaps the same underlying issue, but this bug focuses on the inability to activate the first time, which is more critical.

1. Start with a clean profile
2. Goto https://mozsocial.cliqz.com/
3. Activate
4. Sidebar shows error "Nightly is unable to connect with Cliqz right now"

Restarting Firefox fixes the problem. This problem started to appear in version 25.0a1 (2013-06-25).

Comment 1

[Loic]

Regression range:
good=2013-06-18
bad=2013-06-19
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4e5983de6e3b&tochange=d2a7cfa34154

Suspected bug:
Gavin Sharp — Bug 879658: avoiding exposing localStorage to non-whitelisted social providers, r=mixedpuppy

Comment 3

[Shane Caraveo (:mixedpuppy)]

(In reply to Loic from comment #1)
> Regression range:
> good=2013-06-18
> bad=2013-06-19
> http://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=4e5983de6e3b&tochange=d2a7cfa34154
> 
> Suspected bug:
> Gavin Sharp — Bug 879658: avoiding exposing localStorage to non-whitelisted
> social providers, r=mixedpuppy

Are you able to reproduce this always?  I've never seen it.  Did you look for an console messages?

Comment 4

[edA-qa mort-ora-y]

I get a "localStorage" is not defined error (sorry, copy in the error console doesn't work).

I don't any error when I restart though.

Comment 5

[Loic]

(In reply to Shane Caraveo (:mixedpuppy) from comment #3)
> Are you able to reproduce this always?  I've never seen it.  Did you look
> for an console messages?

Yes, 100% reproducible.

Browser console when I click to activate cliqz:
[16:21:19.435] FrameWorker: Error evaluating worker script for SocialProvider:https://mozsocial.cliqz.com: ReferenceError: localStorage is not defined; Line #160
@https://mozsocial.cliqz.com/worker?version=1.0:160
 @ resource://gre/modules/FrameWorker.jsm:258

Comment 6

[Shane Caraveo (:mixedpuppy)]

Attachment: fix blessed state on activation and update

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 767754 [details] [diff] [review]
fix blessed state on activation and update

I thought addProvider was only called in tests :( Thanks for chasing this down.

nit: add a space to line up the two "activationType"s

Comment 8

[Shane Caraveo (:mixedpuppy)]

bug 879658 was uplifted to fx23

Comment 9

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/51e974db8866

Comment 10

[Shane Caraveo (:mixedpuppy)]

Attachment: fix blessed state on activation and update

fix xpcshell tests

Comment 11

[Shane Caraveo (:mixedpuppy)]

backed out previous patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b955f306226

Comment 12

[Shane Caraveo (:mixedpuppy)]

Attachment: fix blessed state on activation and update

better fix with gavins feedback

https://tbpl.mozilla.org/?tree=Try&rev=4fbb2e2670f4

Comment 13

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/016160c72517

Comment 14

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/016160c72517

Comment 15

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 768039 [details] [diff] [review]
fix blessed state on activation and update

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 879658
User impact if declined: activation of new providers fails
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low, no real alternative other than backing out bug 879658
String or IDL/UUID changes made by this patch: none

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7b87d1785e56
https://hg.mozilla.org/releases/mozilla-beta/rev/9e645dd0a8e1

Comment 17

[u279076]

Samvedana, please verify this is fixed in Firefox 23, 24, and 25.

Comment 18

[Samvedana (:Samvedana)]

User Agent : Mozilla/5.0 (Windows NT 6.2; WOW64; rv:23.0) Gecko/20100101 Firefox/23.0
Build ID : 20130708202947

Tested on Firefox 23-B4, I don't see any connection error. I can activate Social Demo Provider.

User Agent : Mozilla/5.0 (Windows NT 6.2; WOW64; rv:25.0) Gecko/20130711 Firefox/25.0
Build ID:20130711030204

Tested on latest nightly, I don't see any connection error. I can activate Social Demo Provider.

Comment 19

[Samvedana (:Samvedana)]

User Agent : Mozilla/5.0 (Windows NT 6.2; WOW64; rv:24.0) Gecko/20130711 Firefox/24.0
Build ID : 20130711004005

Tested on latest Aurora, I don't see any connection error. I can activate Social Demo Provider.

Comment 20

[Simona Badau]

Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Firefox/24.0
Build ID: 20130812173056

Verified as fixed on Firefox 24 beta 2 - the Social Demo is activated (no connect errors are displayed in the sidebar).

Comment 21

[Simona Badau]

Mozilla/5.0 (X11; Linux x86_64; rv:25.0) Gecko/20100101 Firefox/25.0
Build ID: 20130912004004

Verified as fixed on Firefox 25.0a2.