887256 - Showing "Restart now" link in the Options panel twice is redundant

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Victor Porof [:vporof][:vp]]

Attachment: screenshot

If you chech/uncheck the two settings that require a browser restart in the Options panel, the respective message appears twice. I think that's at least confusing, amongst other things. Do "I need two browser restarts?" "Does Firefox restart itself twice?".

While we're at it. If a checkbox is checked and then unchecked (the original pref is restored), I think the message should disappear, because no browser is required to do nothing.

Comment 1

[Girish Sharma [:Optimizer]]

(In reply to Victor Porof [:vp] from comment #0)
> Created attachment 767735 [details]
> screenshot
> 
> If you chech/uncheck the two settings that require a browser restart in the
> Options panel, the respective message appears twice. I think that's at least
> confusing, amongst other things. Do "I need two browser restarts?" "Does
> Firefox restart itself twice?".

You are thinking to much here :)
Same thing happens in other places too :
on the addons manager page, if two restart-requiring addons get updated, there are two Restart Now links.

But yeah, we can simplify things here.

> While we're at it. If a checkbox is checked and then unchecked (the original
> pref is restored), I think the message should disappear, because no browser
> is required to do nothing.

Yeah, this is what Joe suggested, and I am on it to do this change. I was going to file a bug today only, but you beat me to that.

Comment 2

[Girish Sharma [:Optimizer]]

Attachment: patch v0.1

I think, that the redundant part is the "Restart now" link rather than the "Requires restart" label. The requires restart label signifies that the preference change needs a restart. Thus, it should be present alongside both the options. By showing the "Restart now" link only once, we are making sure that user does not get confused whether he has to restart twice or not.

Also, when the checkbox is clicked even number of times, the label is hidden again.

Also reducing some margins and padding to allow more vertical content without scrollbars.

Comment 3

[Girish Sharma [:Optimizer]]

Attachment: patch v0.2

Some unneeded changes removed.

Comment 4

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/cd7b947248cd

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/cd7b947248cd