Showing "Restart now" link in the Options panel twice is redundant

RESOLVED FIXED in Firefox 25

Status

()

Firefox
Developer Tools: Framework
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vporof, Assigned: Optimizer)

Tracking

unspecified
Firefox 25
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Created attachment 767735 [details]
screenshot

If you chech/uncheck the two settings that require a browser restart in the Options panel, the respective message appears twice. I think that's at least confusing, amongst other things. Do "I need two browser restarts?" "Does Firefox restart itself twice?".

While we're at it. If a checkbox is checked and then unchecked (the original pref is restored), I think the message should disappear, because no browser is required to do nothing.
(Assignee)

Comment 1

5 years ago
(In reply to Victor Porof [:vp] from comment #0)
> Created attachment 767735 [details]
> screenshot
> 
> If you chech/uncheck the two settings that require a browser restart in the
> Options panel, the respective message appears twice. I think that's at least
> confusing, amongst other things. Do "I need two browser restarts?" "Does
> Firefox restart itself twice?".

You are thinking to much here :)
Same thing happens in other places too :
on the addons manager page, if two restart-requiring addons get updated, there are two Restart Now links.

But yeah, we can simplify things here.

> While we're at it. If a checkbox is checked and then unchecked (the original
> pref is restored), I think the message should disappear, because no browser
> is required to do nothing.

Yeah, this is what Joe suggested, and I am on it to do this change. I was going to file a bug today only, but you beat me to that.
Assignee: nobody → scrapmachines
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Created attachment 769436 [details] [diff] [review]
patch v0.1

I think, that the redundant part is the "Restart now" link rather than the "Requires restart" label. The requires restart label signifies that the preference change needs a restart. Thus, it should be present alongside both the options. By showing the "Restart now" link only once, we are making sure that user does not get confused whether he has to restart twice or not.

Also, when the checkbox is clicked even number of times, the label is hidden again.

Also reducing some margins and padding to allow more vertical content without scrollbars.
Attachment #769436 - Flags: review?(jwalker)
(Assignee)

Updated

5 years ago
Summary: Showing "Requires browser restart" in the Options panel twice is redundant → Showing "Restart now" link in the Options panel twice is redundant
(Assignee)

Comment 3

5 years ago
Created attachment 769437 [details] [diff] [review]
patch v0.2

Some unneeded changes removed.
Attachment #769436 - Attachment is obsolete: true
Attachment #769436 - Flags: review?(jwalker)
Attachment #769437 - Flags: review?(jwalker)
Attachment #769437 - Flags: review?(jwalker) → review+
(Assignee)

Updated

5 years ago
Whiteboard: [land-in-fx-team]

Comment 4

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/cd7b947248cd
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/cd7b947248cd
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
You need to log in before you can comment on or make changes to this bug.