887286 - enable crash reporting by default on Nightly and Aurora

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Browser, defect)

Description

[Jim Mathies [:jimm]]

The patches in bug 886794 turn cr off temporarily. I need to figure out the proper way to handle this such that we turn this on by default in nightly builds, and off by default in aurora and up.

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 767787 [details] [diff] [review]
patch

Making sure this is ok with Privacy folks. This is already on by default in our nightly builds, which we probably never got approval for. I believe we do the same on desktop though so I think that should be ok. Expanding this to Aurora as well once we're on that branch.

Comment 3

[Scoobidiver (away)]

(In reply to Jim Mathies [:jimm] from comment #2)
> I believe we do the same on desktop though so I think that should be ok.
On desktop, the crash reporting is on by default on any channels. It's the telemetry that is on by default in Aurora/Nightly channels and off by default in Release/Beta channels.

Comment 4

[Jim Mathies [:jimm]]

(In reply to Scoobidiver from comment #3)
> (In reply to Jim Mathies [:jimm] from comment #2)
> > I believe we do the same on desktop though so I think that should be ok.
> On desktop, the crash reporting is on by default on any channels. It's the
> telemetry that is on by default in Aurora/Nightly channels and off by
> default in Release/Beta channels.

Ok, so then we do need privacy approval on this since we use headless reporting. (There's not crash reporter dialog, we just send the data.) This would be for Nightly and Aurora of course, an approval prompt for other releases is being implemented in bug 886794.

Comment 5

[Curtis Koenig [:curtisk-use curtis.koenig+bzATgmail.com]]]

(In reply to Jim Mathies [:jimm] from comment #4)

> Ok, so then we do need privacy approval on this since we use headless
> reporting. (There's not crash reporter dialog, we just send the data.) This
> would be for Nightly and Aurora of course, an approval prompt for other
> releases is being implemented in bug 886794.

I think it would be a good idea for someone to go over this and ensure we are inline with privacy guidelines on both a policy and technical review.

Comment 6

[Sid Stamm [:geekboy or :sstamm]]

So this totally doesn't need a technical privacy review.

Alina, can we automatically submit crash reports (without asking the user first)?  I think it's reasonable for nightly and aurora, but this is your department.

Jim, Is there UI to turn this off?

Comment 7

[Jim Mathies [:jimm]]

(In reply to Sid Stamm [:geekboy or :sstamm] from comment #6)
> So this totally doesn't need a technical privacy review.
> 
> Alina, can we automatically submit crash reports (without asking the user
> first)?  I think it's reasonable for nightly and aurora, but this is your
> department.
> 
> Jim, Is there UI to turn this off?

Yes, in the Options flyout we have a crashreporter pref switch.

Comment 8

[Sid Stamm [:geekboy or :sstamm]]

Comment on attachment 767787 [details] [diff] [review]
patch

Review of attachment 767787 [details] [diff] [review]:
-----------------------------------------------------------------

This patch should work as advertised... nightly/aurora builds of Firefox Metro will autosubmit crash reports.

Comment 9

[Jim Mathies [:jimm]]

(In reply to Sid Stamm [:geekboy or :sstamm] from comment #8)
> Comment on attachment 767787 [details] [diff] [review]
> patch
> 
> Review of attachment 767787 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This patch should work as advertised... nightly/aurora builds of Firefox
> Metro will autosubmit crash reports.

Thanks. Does this still need privacy approval (privacy-review-needed), or can I go ahead and land it?

Comment 10

[Sid Stamm [:geekboy or :sstamm]]

I think Alina should chime in.  She's been flagged for needinfo since comment 6.  Alina?

Comment 11

[Alina Hua]

Hi all - Sorry for the late reply. I spoke with Ale about enabling crash reporting by default in Nightly and Aurora, and, yes, we're fine with it so long as there is a way for users to turn it off under Settings. 

For future privacy reviews, please file a bug via the Project Kick-Off Form which will automatically file a Privacy bug where we can document the privacy review and resolutions. We may need to update the Privacy Policy section that addresses crash reporting, but I will check on this on Friday when I return from work travel this week.

Comment 12

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/fx-team/rev/0e57ff22d56d

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0e57ff22d56d