887296 - [MMS] Sending a group MMS that contains an invalid number creates two instances of the valid number

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[ayman maat :maat]

[MMS] Sending a group MMS that contains an invalid number creates two instances of the valid number  

**PATH**
1) ensure that a contact exists in the contact list with a valid mobile phone number.
2) open message app
3) select new message 
4) add the contact with the valid phone number to the ‘to field’
5) add a completely invalid number to the 'to field'
6) type something in the message field
7) add an attachment (to ensure format is MMS)
8) select send
9) select the header of the newly created thread to view who the MMS has been sent to


**EXPECTED**
The message will not be sent due to the invalid phone number
The message will not be sent to the same number twice


**ACTUAL**
Two separate instances of the same contact are shown in the dialogue that informs the user who the message has been sent to

11) Select first instance of the contact
Contact details for valid contact added in step 4) are observed

12) Select second instance of the contact
Contact details for valid contact added in step 4) are also observed


Refer to attached documentation for illustration of current erroneous flow

Comment 1

[ayman maat :maat]

Attachment: HTML5_SMS-MMSBugFlow_20130627_Bug887296_V0.1

Reference comment #0

Comment 2

[Julien Wajsberg [:julienw]]

Ayman, was the message sent to the valid number ?

Comment 3

[Julien Wajsberg [:julienw]]

Rick was looking for some bugs ;)

Comment 4

[ayman maat :maat]

(In reply to Julien Wajsberg [:julienw] from comment #2)
> Ayman, was the message sent to the valid number ?

one number is valid, one number is invalid.

Comment 5

[Rick Waldron [:rwaldron]]

Woo! These bug flows are great!

(In reply to ayman maat :maat from comment #1)
> Created attachment 767795 [details]
> HTML5_SMS-MMSBugFlow_20130627_Bug887296_V0.1
> 
> Reference comment #0


Following this bug flow, I documented the current behaviour: 

  https://www.dropbox.com/sh/h1o2rdk92ifi7iu/LuJ9YWKs7q

as it appears on: 

  gaia/master@d34e713d09ac1fadf1e471cca441fcdb93b119b9


The only obvious issue (that I can see) is the carrier tag (which is fixed in bug 885264)

Comment 6

[Julien Wajsberg [:julienw]]

(In reply to ayman maat :maat from comment #4)
> (In reply to Julien Wajsberg [:julienw] from comment #2)
> > Ayman, was the message sent to the valid number ?
> 
> one number is valid, one number is invalid.

I mean, was the message actually received by the valid number ?

Comment 7

[Julien Wajsberg [:julienw]]

(In reply to Rick Waldron from comment #5)
> Woo! These bug flows are great!
> 
> (In reply to ayman maat :maat from comment #1)
> > Created attachment 767795 [details]
> > HTML5_SMS-MMSBugFlow_20130627_Bug887296_V0.1
> > 
> > Reference comment #0
> 
> 
> Following this bug flow, I documented the current behaviour: 
> 
>   https://www.dropbox.com/sh/h1o2rdk92ifi7iu/LuJ9YWKs7q
> 
> as it appears on: 
> 
>   gaia/master@d34e713d09ac1fadf1e471cca441fcdb93b119b9
> 
> 
> The only obvious issue (that I can see) is the carrier tag (which is fixed
> in bug 885264)

Could it happen only in v1-train ? Ayman, what version were you using ?

Comment 8

[ayman maat :maat]

cannot reproduce any more so resolving as Fixed

**TESTED ON**
build-20130701101518
Gecko-f9597b2
Gaia-c7472ac