Closed Bug 887314 Opened 9 years ago Closed 9 years ago

The camera icon is distorted on a retina screen

Categories

(Firefox Graveyard :: SocialAPI, defect)

x86
macOS
defect
Not set
normal

Tracking

(firefox24 affected, firefox25 verified)

VERIFIED FIXED
Firefox 25
Tracking Status
firefox24 --- affected
firefox25 --- verified

People

(Reporter: florian, Assigned: florian)

Details

Attachments

(3 files)

Attached patch PatchSplinter Review
The attached patch:
- Fixes the size of notification icons in the chat title bar on a retina screen. The problem was that the width css property set on the toolbarbutton wasn't propagated to the image tag.
- Prevents the minimize/tear-off/close icons from moving 1px down when a notification is shown and 1px up when the notification icon is removed. (These icons moving around are noticeable when the device permissions are granted and the camera grey icon is removed and then replaced by the green one.)
- Replaces id="notification-icon" by anonid="notification-icon" in socialchat.xml and fix the indent on the next line. I don't think setting an id on an anonymous element was intended.
Attachment #767807 - Flags: review?(mixedpuppy)
On the left side, a current nightly. On the right side a build with attachment 767807 [details] [diff] [review] included.
On the left side, a current nightly. On the right side a build with attachment 767807 [details] [diff] [review] included.
Assignee: nobody → florian
Comment on attachment 767807 [details] [diff] [review]
Patch

looks good.  I only tested on non-retina.
Attachment #767807 - Flags: review?(mixedpuppy) → review+
(In reply to Shane Caraveo (:mixedpuppy) from comment #3)
> Comment on attachment 767807 [details] [diff] [review]
> Patch
> 
> looks good.  I only tested on non-retina.

Thanks for the quick review! I tested on a retina screen so I'm not worried about that. The part where I'm not sure is if my css changes will have a visible effect on Windows/Linux. Is this worth pushing to try and requesting that QA people test it? Or should we just land for nightlies and get feedback after the fact?
Mark, could you test this patch on windows?  You can get the permissions icons with the Talkilla service @ https://talkilla.mozillalabs.com/
Looks fine to me - I see the camera icon in the title bar and it looks how I'd expect.
https://hg.mozilla.org/mozilla-central/rev/69c127a9d30f
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Matt, can you please verify this is fixed on your retina Mac?
Keywords: verifyme
QA Contact: mwobensmith
Apologies for being so obvious, but to verify, I need a URL and/or steps. I don't know how to recreate this bug, in order to verify it fixed. Thank you in advance.
(In reply to Matt Wobensmith from comment #10)
> Apologies for being so obvious, but to verify, I need a URL and/or steps. I
> don't know how to recreate this bug, in order to verify it fixed. Thank you
> in advance.

Use the demo provider at http://mixedpuppy.github.io/socialapi-demo/ and open a chat window from the sidebar.  It has a button to "start camera".  It doesn't actually do anything with the camera, just enough to get the permissions panel to show up.
Thanks for the help, Shane. 

Confirmed bug on FF25 2013-06-26.
Verified fixed on FF25 2013-09-23.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.