887354 - Homescreen dock test failing on TBPL

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Jonathan Griffin (:jgriffin)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=24576476&tree=Cedar

11:35:02     INFO -  gaia-unit-tests TEST-UNEXPECTED-FAIL | dock.js > with 0 icons > moveBy was called | expected 0 to be truthy
11:35:02     INFO -  gaia-unit-tests INFO       | stack trace:
11:35:02     INFO -      Error: expected 0 to be truthy
11:35:02     INFO -          at chaiAssert (http://test-agent.gaiamobile.org:8080/common/test/helper.js:30)
11:35:02     INFO -          at get (http://test-agent.gaiamobile.org:8080/common/vendor/chai/chai.js:352)
11:35:02     INFO -          at ok (http://test-agent.gaiamobile.org:8080/common/vendor/chai/chai.js:1225)
11:35:02     INFO -          at (anonymous) (http://homescreen.gaiamobile.org:8080/test/unit/dock_test.js:120)
11:35:02     INFO -          at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:62)
11:35:02     INFO -          at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)
11:35:02     INFO -          at runTest (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081)
11:35:02     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127)
11:35:02     INFO -          at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007)
11:35:02     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016)
11:35:02     INFO -          at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964)
11:35:02     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3979)
11:35:02     INFO -          at done (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3700)
11:35:02     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3712)
11:35:02     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:46)
11:35:02     INFO -          at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:73)
11:35:02     INFO -          at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)
11:35:02     INFO -          at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973)
11:35:02     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984)
11:35:02     INFO -          at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932)

Comment 1

[Julien Wajsberg [:julienw]]

That would mean the innerWidth is 0 ? I'll try to run them in b2g desktop instead of nightly.

Comment 2

[Julien Wajsberg [:julienw]]

I don't know how to run unit tests in b2g desktop :( without a debug profile I can't launch tests, and with a debug profile the b2g desktop stays black.

Cristian, I think you did that a few days ago, could you help me here ?

Comment 3

[Cristian Rodriguez (:crdlc)]

yep, I can help you, don't worry my friend, other thing is what I will find the problem jijiji

Comment 4

[Cristian Rodriguez (:crdlc)]

The B2G Desktop gets black with:

./b2g-bin --screen=480x800 -profile /Users/crdlc/development/repos/crdlc/test/gaia/profile-debug &

Maybe after some update because it was working 2 days ago

Comment 5

[Cristian Rodriguez (:crdlc)]

I try to download this one

http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/latest-mozilla-central/b2g-25.0a1.multi.mac64.dmg

Comment 6

[Cristian Rodriguez (:crdlc)]

Timestamp: 27/06/13 10:13:42
Warning: ReferenceError: reference to undefined property this.result['homescreen.manifestURL']
Source File: http://system.gaiamobile.org:8080/js/window_manager.js
Line: 934

maybe it is the bug, I can see the logo "based on mozilla technology"

Comment 7

[Cristian Rodriguez (:crdlc)]

Attachment: Setting innerWitdth

I don't see other reason to fail it

Comment 8

[Cristian Rodriguez (:crdlc)]

Here you can see the pull request, I would like to know if Travis still works fine

https://github.com/mozilla-b2g/gaia/pull/10663

Comment 9

[Julien Wajsberg [:julienw]]

using a DEBUG=1 DESKTOP=0 profile I manage to start b2g desktop but not launching tests;

jgriffin, how do you generate your gaia profile ?

Comment 10

[Jonathan Griffin (:jgriffin)]

We are just using DEBUG=1 NOFTU=1

Comment 11

[Alexandre Poirot [:ochameau]]

I opened bug 885544 to prevent from having to pass DESKTOP=0.
Hopefully you shouldn't have to modify anything if we finally land a fix for this bug.

Comment 12

[Jonathan Griffin (:jgriffin)]

For now, disabled this test in https://github.com/mozilla-b2g/gaia/commit/8a52616318758661c6c75bded3fc33881bd665fb so we can get a green run on TBPL.

Comment 13

[Julien Wajsberg [:julienw]]

I don't really like the fix from Cristian, this feels like a hack... so waiting until I come back from PTO.

Comment 14

[Julien Wajsberg [:julienw]]

I actually think it works now.

In Bug 999553 I reenable this test and it doesn't fail on TBPL. Moreover I ran it on B2G Desktop and it passed locally. So I think a fix either in homescreen or B2G Desktop has been done :)