The default bug view has changed. See this FAQ.

Change "= 0" assignments for ptrs in nsHttpChannel to "= nullptr"

RESOLVED FIXED in mozilla25

Status

()

Core
Networking: HTTP
--
trivial
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: sworkman, Assigned: Adrian Lungu)

Tracking

unspecified
mozilla25
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Many pointers in nsHttpChannel are nulled out using 0 instead of nullptr. These should be changed to nullptr. In addition, change nullptr checks to "(!ptr)" and not "(ptr != 0)".

Note: This is a good first bug to develop familiarity with Bugzilla and the patch landing process.
(Assignee)

Comment 1

4 years ago
Created attachment 768084 [details] [diff] [review]
The patch containing the bugfix
Attachment #768084 - Flags: review?(sworkman)
(Reporter)

Comment 2

4 years ago
Comment on attachment 768084 [details] [diff] [review]
The patch containing the bugfix

Review of attachment 768084 [details] [diff] [review]:
-----------------------------------------------------------------

Good job. Thanks for doing that.
Attachment #768084 - Flags: review?(sworkman) → review+
steve can review this.
(Reporter)

Comment 4

4 years ago
Thanks Pat!
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Reporter)

Comment 5

4 years ago
I'll do this right after lunch - removed "checkin-needed" in case someone sees it in the meantime :)
Keywords: checkin-needed
(Reporter)

Comment 6

4 years ago
Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/36fe6903a0be
(Reporter)

Comment 7

4 years ago
Aagh - I didn't set the name right - sorry, Adrian! Next time, we'll make sure it has your name on it.
https://hg.mozilla.org/mozilla-central/rev/36fe6903a0be
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.