887447 - Surface dies after visiting internal browser page; XUL window popup in-focus

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (06/26) - Screenshot

Currently I am seeing the browser surface go bad after visiting one of our internal pages.

STR:

i) Visit about:support
ii) Tap the 'View Update History' button
iii) Tap the location-bar and head to Google.com

W/Adreno200-EGL( 9334): <qeglDrvAPI_eglMakeCurrent:2762>: EGL_BAD_SURFACE
E/libEGL  ( 9334): eglMakeCurrent:593 error 300d (EGL_BAD_SURFACE)

See screenshot where I am at Google yet I see previous content.

--
Nightly (06/26)
Samsung Galaxy SIV (Android 4.2.2)

Comment 1

[Aaron Train [:aaronmt]]

This affects the current state of the browser in that any site visited afterwards isn't drawn to our surface. A force-stop and re-opening of the browser is the only work-around as far as I'm aware.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Screenshot with bugzilla under the XUL Window

This looks like some stupid XUL window popped up on top of the page. See for instance the attached screenshot. There is a "close" button in the bottom-right of this XUL window but touch events may not be getting delivered to it properly so you can't actually close it.

We should replace the XUL window with some more Android-y.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

We need to implement this interface in Fennec: http://mxr.mozilla.org/mozilla-central/source/toolkit/content/aboutSupport.js#509

Comment 4

[Geoff Lankow (:darktrojan)]

It'd be easier not to show the button on Android. I guess that depends if you're going to implement the update history window anyway.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

What is that window supposed to show anyway?

Comment 6

[Geoff Lankow (:darktrojan)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #5)
> What is that window supposed to show anyway?

It's a list of application updates, version numbers and update status. Since most Android updates are probably done with the Play store, I'll get rid of it for Android.

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: patch

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Thanks. Note that ANDROID includes B2G. For Fennec only please use MOZ_WIDGET_ANDROID.

Comment 9

[Geoff Lankow (:darktrojan)]

I didn't know that, but I guess the button isn't wanted on B2G either.

Comment 10

[Drew Willcoxon :adw]

Comment on attachment 768821 [details] [diff] [review]
patch

Review of attachment 768821 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/content/aboutSupport.xhtml
@@ +94,4 @@
>              </td>
>            </tr>
>  
> +#endif

Übernit: Please move the #endif up a line so that it nestles the </tr> and the block of markup it applies to.

Comment 11

[Geoff Lankow (:darktrojan)]

(In reply to Drew Willcoxon :adw from comment #10)
> Übernit: Please move the #endif up a line so that it nestles the </tr> and
> the block of markup it applies to.

I'd decided to keep the white space looking pretty after processing. On the source that probably nobody's ever going to look at. I am not a smart man. :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c8e6f8e6715

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1c8e6f8e6715

Comment 13

[Geoff Lankow (:darktrojan)]

Attachment: patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 864251
User impact if declined: Firefox for Android becomes unusable
Testing completed (on m-c, etc.): On m-c for 48 hours
Risk to taking this patch (and alternatives if risky): Virtually none
String or IDL/UUID changes made by this patch: None

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6ce2c7dbe680