887494 - Bug 884124 introduced a new struct/class mismatch

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Emanuel Hoogeveen [:ehoogeveen]]

Attachment: Fix struct/class mismatch introduced by part 4 of 884124 and fix a "used but never defined" warning

As the summary says, bug 884124 introduced a struct/class mismatch in vm/ErrorObject.h, which it added. Said file was probably developed against an older version of the tree (i.e. before bug 886128).

This patch fixes that mismatch, and also adds an include to jsexn.cpp to squash the last "used but never defined" warning (not fixed by part 9 of bug 886205).

I hope this is the last time this warning crops up for a while. Are there any plans to turn this warning into an error? The problem it catches sometimes show up as linker errors, but I'm worried about when they don't. Clang, at least, is pretty good at telling you where the problem originates.

Comment 1

[Nicholas Nethercote [inactive]]

Comment on attachment 767997 [details] [diff] [review]
Fix struct/class mismatch introduced by part 4 of 884124 and fix a "used but never defined" warning

Review of attachment 767997 [details] [diff] [review]:
-----------------------------------------------------------------

jsexn.cpp already has |#include "jsfunlines.h"|.  But I'll land the struct mismatch;  thanks for catching it.

Comment 2

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f857417260a9

Comment 3

[Emanuel Hoogeveen [:ehoogeveen]]

I guess someone else caught it first :) Thanks for the review!

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f857417260a9