Closed Bug 887516 Opened 11 years ago Closed 11 years ago

Display "Class" instead of "[object Class]" in the VariablesView

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 25

People

(Reporter: bbenvie, Assigned: bbenvie)

Details

Attachments

(1 file, 3 obsolete files)

change and test fixes
34.67 KB, patch
vporof
: review+
Details | Diff | Splinter Review 
Using "[object *]" just adds a lot of useless repetitive noise, while also forcing longer class names to not fit and use ellipses.
Attached patch change (obsolete) — — Splinter Review 
Changes the single call to VariablesView.getString to pass in `true` for the concise flag.
Assignee: nobody → bbenvie
Attachment #768029 - Flags: review?(vporof)
Attached patch change and test fixes (obsolete) — — Splinter Review 
Totally forgot to update tests. <:|

https://tbpl.mozilla.org/?tree=Try&rev=aec749c35fc1
Attachment #768029 - Attachment is obsolete: true
Attachment #768029 - Flags: review?(vporof)
Attachment #768085 - Flags: review?(vporof)
Attached patch change test fixes (obsolete) — — Splinter Review 
blarg
Attachment #768085 - Attachment is obsolete: true
Attachment #768085 - Flags: review?(vporof)
Attachment #768087 - Flags: review?(vporof)
Comment on attachment 768087 [details] [diff] [review]
change test fixes

I have more tests to fix I guess.
Attachment #768087 - Flags: review?(vporof)
Let's try this again.

https://tbpl.mozilla.org/?tree=Try&rev=d0dcc2046d55
Attachment #768087 - Attachment is obsolete: true
(In reply to Victor Porof [:vp] from comment #5)
> Dupe of bug 755412?

I mean bug 753332.
Attachment #768371 - Flags: review?(vporof)
Comment on attachment 768371 [details] [diff] [review]
change and test fixes

Review of attachment 768371 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok.
Attachment #768371 - Flags: review?(vporof) → review+
Whiteboard: [land-in-fx-team]
Landed: https://hg.mozilla.org/integration/fx-team/rev/c7ef33936293
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/c7ef33936293
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: