887545 - [User Story] Make a call via BT headset button

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[Wilfred Mathanaraj [:WDM]]

User Story:

As a user I want to execute the call function on the BT headset to make a call using the last MO number.

Preconditions:

* Dialer app is not open
* There is no MO and MT call currently taking place on the calling device
* Headset is connected to the device

Acceptance Criteria:

* Dialer app is opened and a MO call is placed with the last MO number
* Dialer app indicates any errors in a comprehensible message
* If there is no MO call in the call log the user is informed accordingly

Comment 1

[Eric Chou [:ericchou] [:echou]]

The implemention of Gecko has been done since v1.0.1. It's part of certification of HFP (Handsfree Profile). For people who wants to know Gecko implementation of this user story, please refer to links below:

[1] bug 869296
[2] bug 876640
[3] http://dxr.mozilla.org/mozilla-central/source/dom/bluetooth/BluetoothHfpManager.cpp#l852

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

koi+ as it is listed as a must have in v1.2 for COMM

per COMM team meeting, QAWANTED to confirm feature. might be working already
"QA to verify this (the last outgoing call to be dialed). May be done already"

Comment 3

[Al Tsai [:atsai]]

Testing on my unagi v1.1 with Jabra wave + bluetooth headset.

The function works well as expected.

Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/5cddbe066fe9
Gaia   c7472acec84f0d4527cdd6fd555d289e1d3e1d1d
BuildID 20130630230208
Version 18.0

Comment 4

[Wilfred Mathanaraj [:WDM]]

Can you confirm the call you made was with the last MO number?

Comment 5

[Al Tsai [:atsai]]

https://moztrap.mozilla.org/manage/case/8457/

It's in mozTrap already.
Attempt to close it as WFM.

Comment 6

[Al Tsai [:atsai]]

(In reply to Wilfred Mathanaraj [:WDM] from comment #4)
> Can you confirm the call you made was with the last MO number?

Confirmed. The call I made was with the last MO number.


STR:
0) w/ Bluetooth headset connected
1) Originate a call from DuT, and hang off
2) Make a call to DuT from another number, and hang off
3) Trigger the redial from bluetooth headset

Expected Result:
*) redial to the number in step 1

Actual Result:
*) redial to the number in step 1

Comment 7

[Eric Chou [:ericchou] [:echou]]

(In reply to Al Tsai [:atsai] from comment #6)
> (In reply to Wilfred Mathanaraj [:WDM] from comment #4)
> > Can you confirm the call you made was with the last MO number?
> 
> Confirmed. The call I made was with the last MO number.
> 
> 
> STR:
> 0) w/ Bluetooth headset connected
> 1) Originate a call from DuT, and hang off
> 2) Make a call to DuT from another number, and hang off
> 3) Trigger the redial from bluetooth headset
> 
> Expected Result:
> *) redial to the number in step 1
> 
> Actual Result:
> *) redial to the number in step 1

At the very beginning, the last call number (no matter MO or MT) in the call history would be chosen. So we filed a bug (bug 877070), asking for help from Dialer app. Please see that bug for more information.

Comment 8

[Al Tsai [:atsai]]

MozTrap # 9044

Comment 9

[Stephany Wilkes]

The DRAFT spec for "dial the last number" is currently posted here. Eng will ensure this works from the headset. 
https://mozilla.app.box.com/profile/196633958/page/0/1/9023829589

Comment 10

[Eric Chou [:ericchou] [:echou]]

Hi Stephany,

(In reply to Stephany Wilkes from comment #9)
> The DRAFT spec for "dial the last number" is currently posted here. Eng will
> ensure this works from the headset. 
> https://mozilla.app.box.com/profile/196633958/page/0/1/9023829589

I can't see the page. It says "User profile not available". Did I miss anything?

Comment 11

[Germán Toro del Valle (:gtorodelvalle)]

Hi guys! You may want to have a look at the implementation (already in master of bug 887488 and more concretely of bug 892880) to reuse this code if appropriate, as already commented at the Stand Up meeting for the COMM team ;-)

Comment 12

[Joe Cheng [:jcheng] (please needinfo)]

i believe Francis provided it separately in email https://mozilla.box.com/s/145btk0x5dpkibpzhbvr

Comment 13

[Paul Yang [:pyang] (away)]

According to ux spec, verified ok on 
Gaia:     9c59dd4440802f8a481943ce1db60b40636d26e3
B-D     2013-08-09 21:26:02
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/1433d653b701
BuildID   20130808041202
Version   18.0

Comment 14

[Joe Cheng [:jcheng] (please needinfo)]

per comment 13. closing