887564 - [contacts] the number is shown in the edit page when there is no name

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
* edit a contact
* remove the given name and the family name
* save the contact
* tap the edit button again

Expected:
* the given and family names are still empty

Actual:
* the given name input has the first phone number displayed

Moreover, if, at the step 4, you first press the back button to go at the contact list, then load the contact again, and edit the contact, then the expected behavior happens !

I also checked (from the Sms app) that the given name is actually empty in the database.

This is probably not a blocker, but if the fix is small it could still be a good idea to leo+ it after the fact.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

This is likely the culprit:

  https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/js/contacts_list.js#L765

We should probably return the normalized string to use elsewhere instead of setting the givenName to it.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Taking this since I'm already neck deep in the code.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10673

Pointer to Github pull-request

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 768341 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/10673

Nice refactor with a good documentation for the method, thanks a lot.

Tried on the phone and working perfectly.

r+++!

F.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Landed

https://github.com/mozilla-b2g/gaia/commit/088e2ad5f35ac192ed3b2b623da7bfe48ad8ae94