Closed
Bug 887577
Opened 11 years ago
Closed 11 years ago
[AccessFu] Don't throw exception when Utils.getAttributes doesn't get a supported accessible
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: eeejay, Assigned: eeejay)
References
Details
Attachments
(1 file)
Apparently the root accessible does not have an attributes field. So we get an exception when trying to get its attributes. We should probably just return an empty object. Also in the case of a null argument.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → eitan
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #768075 -
Flags: review?(yura.zenevich)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 768075 [details] [diff] [review] Return empty object when accessible is null, or when it has no attributes field. Review of attachment 768075 [details] [diff] [review]: ----------------------------------------------------------------- Looks good!
Attachment #768075 -
Flags: review?(yura.zenevich) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3df3e6a00611
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3df3e6a00611
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•