Closed Bug 887580 Opened 11 years ago Closed 11 years ago

files should properly export objects by attaching them directly to the global scope

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Product:
Firefox Health Report Graveyard
Component:
Client: Desktop
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 26

People

(Reporter: smirea, Assigned: smirea)

Details

Attachments

(1 file)

properly export object in profile.jsm and policy.jsm
4.40 KB, patch
gps
: review+
Details | Diff | Splinter Review 
Similar to Bug 887081

In order to maximize compatibility, exported objects should be attached to the global scope instead of defining them as functions (i.e. this.ProfileCreationTimeAccessor instead of function ProfileCreationTimeAccessor)
Otherwise tests fail on platforms like Boot 2 Gecko

Currently in:
services/datareporting/policy.jsm
services/healthreport/profile.jsm
Changed "profile.jsm" and "policy.jsm" to bind the exported objects to the global scope
Attachment #768078 - Flags: review?(gps)
Attachment #768078 - Flags: review?(gps) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8105a07af658
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: