887582 - [AccessFu] have logException support XPC errors

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

We could get a full stack trace on those kinds of errors too.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: improve logException

This also cleans up the output a bit and adds a new error message argument to the function. Now errors are pretty to look at and easier to find.

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 768083 [details] [diff] [review]
improve logException

Review of attachment 768083 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with just that one change.

::: accessible/src/jsat/Utils.jsm
@@ +270,5 @@
>      this.log.apply(
>        this, [this.ERROR].concat(Array.prototype.slice.call(arguments)));
>    },
>  
> +  logException: function logException(aException, aErrorMessage) {

It would be really elegant to use a default argument value here so you could avoid line 276 altogether:
logException: function logException(aException, aErrorMessage = 'An exception has occured') {
  ...
}

Comment 3

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ce7f9b9b2da2

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ce7f9b9b2da2