887651 - [SMS] Contact name is double escaped in Notification

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Corey Frang [:gnarf]]

Attachment: screenshot of error

When receiving an SMS from a contact that has <>' or other escaped html characters, the notification will display with &lt;&gt;&apos; etc.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

I think the problem is from ...
Activity_handler.js , sender = Utils.escapeHTML(contact[0].name[0]);

Comment 2

[Jakub Siemiatkowski (:sasklacz)]

I've found the same place and this fixes the error. But are we sure contact in all cases is saved with escaped name ?

Comment 3

[Michał Budzyński (:michalbe)]

I think it doesn't matter since we use textContent and not innerHTML to display name.

Comment 4

[Eric O'Connor [:oconnore]]

Attachment: Github pull request

Jakub -- contacts are not saved with escaped name. The escaping should be done by the rendering code, which it is in apps/system/js/notifications.js:257. 

Sorry for dropping the patch in, I forgot to take this and didn't notice it had been assigned.

Comment 5

[Corey Frang [:gnarf]]

Comment on attachment 768717 [details] [review]
Github pull request

r=me - landing

Comment 6

[Corey Frang [:gnarf]]

master: https://github.com/mozilla-b2g/gaia/commit/1f930aa69241162095fc59cb63faad56ccf0c004
v1-train: https://github.com/mozilla-b2g/gaia/commit/9c9f1445afadcfd7078311341d35800f696fc90d

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8e96021bb7a8

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 9c9f1445afadcfd7078311341d35800f696fc90d

Comment 9

[sbogati]

Issue longer reproduces in the Leo 
Build ID: 20130716070204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/629020cf576b
Gaia: fb9362d34260771d4a00b9a0e10a6bbad397bd3b
Platform Version: 18.1
Contact name no longer double escaped in Notification. Result as expected.