88768 - unary minus operator applied to unsigned type, result still unsigned

Status: VERIFIED FIXED

(Core :: Networking: Cache, defect)

Description

[timeless]

warning from 092 branch:
mozilla\netwerk\cache\src\nsCacheEntryDescriptor.cpp(606) : warning C4146: 
unary minus operator applied to unsigned type, result still unsigned

606                     PRInt32 delta = -cacheEntry->DataSize();

Comment 1

[Doug Turner (:dougt)]

John, can you whip of a fix for this?

Comment 2

[John Taylor]

Attachment: Removes minus operator

Comment 3

[John Taylor]

The minus sign didn't seem to be doing anything, so I removed it (see patch).
dougt: can you review?

Comment 4

[Doug Turner (:dougt)]

hmm.
shouldn't it be something like:

PRInt32 delta = cacheEntry->DataSize();
rv = device->OnDataSizeChange(cacheEntry, -delta);

Comment 5

[John Taylor]

Attachment: New patch, using dougt's comments.

Comment 6

[John Taylor]

-> gordon. This should be very quick. I am not familiar with the cache code, and
what OnDataSizeChange is doing. Mind taking a look?

Comment 7

[Tomi Leppikangas]

*** Bug 91635 has been marked as a duplicate of this bug. ***

Comment 8

[Jaime Rodriguez, Jr.]

Gordon/Gagan - Is this worthy of a nsbranch+ nomination.

Pls help . . . we are trying to get a good picture of what work is left for the
next release.

Comment 9

[gordon]

I think this is a safe change to make.  I'm not aware of any user reported bugs
attributable to this however.  I'll land this on the trunk, and I'm willing to
land it on the branch as well.

Comment 10

[Nisheeth Ranjan]

I think this is very low risk and should be allowed onto the branch.  Marking
nsbranch+.  Gordon, please check this in on the 0.9.4 branch.  Thanks!

Comment 11

[Asa Dotzler [:asa]]

0.9.4 is out the door.

Comment 12

[gordon]

Fix checked into trunk and branch.

Comment 13

[gordon]

Marking FIXED.

Comment 14

[benc]

gordon: since you reviewed this patch, can you mark this bug as verified?

Comment 15

[gordon]

Marking VERIFIED.