88775 - uncaught exception when creating folders that already exist

Status: NEW

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Henrik Gemal]

If you try to create a folder under Local Folders that already exist you get:

Error: uncaught exception: [Exception... "Component returned failure code: 
0x80550013 [nsIRDFCompositeDataSource.DoCommand]"  nsresult: "0x80550013 
(<unknown>)"  location: "JS frame :: chrome://messenger/content/mailCommands.js 
:: DoRDFCommand :: line 50"  data: no]

reproduce:
1) create folder "t" under Local Folder
2) try to create folder "t" again under Local Folder


20010730

Comment 1

[Christian Ehrlicher]

I've tried with Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.7) Gecko/20040616
and this doesn't happen anymore. Also tried with 1.7/win32 and it works there too.
Bug #90113 also seems to be fixed.

Comment 2

[Wayne Mery (:wsmwk)]

(In reply to comment #1)
> I've tried with Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.7) Gecko/20040616
> and this doesn't happen anymore. Also tried with 1.7/win32 and it works there too.

Still happens under windows 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060522 SeaMonkey/1.5a


Why is bug 90111 not a duplicate? Looks/tests same to me.

Comment 3

[Wayne Mery (:wsmwk)]

(In reply to comment #2)
>...
> Still happens under windows 
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060522
> SeaMonkey/1.5a
> 
> 
> Why is bug 90111 not a duplicate? Looks/tests same to me.

this, bug 65303 and bug 90111 all the same?

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to comment #3)
> this, bug 65303 and bug 90111 all the same?

It seems bug 65303 was about something (quite) different, wasn't it ?

*****

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008051803 Thunderbird/3.0a2pre] (nightly) (W2Ksp4)

{{
Error: [Exception... "Component returned failure code: 0x80550013 [nsIMsgFolder.createSubfolder]"  nsresult: "0x80550013 (<unknown>)"  location: "JS frame :: chrome://messenger/content/mailCommands.js :: NewFolder :: line 308"  data: no]
Source File: chrome://messenger/content/mailCommands.js
Line: 308
}}

***

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008052007 SeaMonkey/2.0a1pre] (SEA-WIN32-TBOX-trunk) (W2Ksp4)

{{
Error: uncaught exception: [Exception... "Component returned failure code: 0x80550013 [nsIRDFCompositeDataSource.DoCommand]"  nsresult: "0x80550013 (<unknown>)"  location: "JS frame :: chrome://messenger/content/mailCommands.js :: DoRDFCommand :: line 53"  data: no]
}}

Need to use Venkman to get the details:
{{
Error: uncaught exception: [Exception... "Component returned failure code: 0x80550013 [nsIRDFCompositeDataSource.DoCommand]"  nsresult: "0x80550013 (<unknown>)"  location: "JS frame :: chrome://messenger/content/mailCommands.js :: DoRDFCommand :: line 53"  data: no]

Exception ``[Exception... "Component returned failure code: 0x80550013 [nsIRDFCompositeDataSource.DoCommand]" nsresult: "0x80550013 (<unknown>)" location: "JS frame :: chrome://messenger/content/mailCommands.js :: DoRDFCommand :: line 53" data: no]'' thrown from function DoRDFCommand(argumentArray=XPComponent:{18}, srcArray=XPComponent:{18}, command=string:"http://home.netscape.com/NC-rdf#NewFolder", dataSource=XPComponent:{28}) in <chrome://messenger/content/mailCommands.js> line 53.

Exception ``[Exception... "Component returned failure code: 0x80550013 [nsIRDFCompositeDataSource.DoCommand]" nsresult: "0x80550013 (<unknown>)" location: "JS frame :: chrome://messenger/content/mailCommands.js :: DoRDFCommand :: line 53" data: no]'' thrown from function DoRDFCommand() in <chrome://messenger/content/mailCommands.js> line 57.

Exception ``[Exception... "Component returned failure code: 0x80550013 [nsIRDFCompositeDataSource.DoCommand]" nsresult: "0x80550013 (<unknown>)" location: "JS frame :: chrome://messenger/content/mailCommands.js :: DoRDFCommand :: line 53" data: no]'' thrown from function NewFolder(uri=string:"mailbox://nobody@Local%20Folders", name=string:"t") in <chrome://messenger/content/mailCommands.js> line 369.

Exception ``[Exception... "Component returned failure code: 0x80550013 [nsIRDFCompositeDataSource.DoCommand]" nsresult: "0x80550013 (<unknown>)" location: "JS frame :: chrome://messenger/content/mailCommands.js :: DoRDFCommand :: line 53" data: no]'' thrown from function onOK() in <chrome://messenger/content/newFolderDialog.js> line 91.

Exception ``[Exception... "Component returned failure code: 0x80550013 [nsIRDFCompositeDataSource.DoCommand]" nsresult: "0x80550013 (<unknown>)" location: "JS frame :: chrome://messenger/content/mailCommands.js :: DoRDFCommand :: line 53" data: no]'' thrown from function anonymous(event=Event:{0}) in <chrome://global/content/bindings/dialog.xml> line 357.

Exception ``[Exception... "Component returned failure code: 0x80550013 [nsIRDFCompositeDataSource.DoCommand]" nsresult: "0x80550013 (<unknown>)" location: "JS frame :: chrome://messenger/content/mailCommands.js :: DoRDFCommand :: line 53" data: no]'' thrown from function _fireButtonEvent(aDlgType=string:"accept") in <chrome://global/content/bindings/dialog.xml> line 358.

Exception ``[Exception... "Component returned failure code: 0x80550013 [nsIRDFCompositeDataSource.DoCommand]" nsresult: "0x80550013 (<unknown>)" location: "JS frame :: chrome://messenger/content/mailCommands.js :: DoRDFCommand :: line 53" data: no]'' thrown from function _doButtonCommand(aDlgType=string:"accept") in <chrome://global/content/bindings/dialog.xml> line 332.

Exception ``[Exception... "Component returned failure code: 0x80550013 [nsIRDFCompositeDataSource.DoCommand]" nsresult: "0x80550013 (<unknown>)" location: "JS frame :: chrome://messenger/content/mailCommands.js :: DoRDFCommand :: line 53" data: no]'' thrown from function _handleButtonCommand(aEvent=XULCommandEvent:{0}) in <chrome://global/content/bindings/dialog.xml> line 321.
}}
which points to the "same" function:
{{
function NewFolder(uri=string:"mailbox://nobody@Local%20Folders", name=string:"t") in <chrome://messenger/content/mailCommands.js> line 369.
}}

Suggestions:
*Look into synchronizing SM code from TB one.
*Fix the issue.
 *At least, adding a try+catch to SM code fixes this bug.
  But the dialog is closed: would there be a way to keep it open in this case ?
 *In fact, I think the RDF code should rather not be called after/when validating the dialog which reports the duplication...
  I haven't look into that yet.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #5)
>  *In fact, I think the RDF code should rather not be called after/when
> validating the dialog which reports the duplication...
>   I haven't look into that yet.

I think the dialog is triggered by
<http://mxr.mozilla.org/seamonkey/source/mailnews/local/src/nsLocalMailFolder.cpp>
{{
696 nsMsgLocalMailFolder::CreateSubfolder(const nsAString& folderName, nsIMsgWindow *msgWindow )

726     ThrowAlertMsg("folderExists", msgWindow);
727     return NS_MSG_FOLDER_EXISTS;
}}

But I don't know enough to do more on this very issue.

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <mailnews/*.cpp> cleanup/sync

Not (this) bug, but noticed while working on it.

(Untested.)

Comment 8

[David :Bienvenu]

Comment on attachment 321845 [details] [diff] [review]
(Av1) <mailnews/*.cpp> cleanup/sync

I don't think this will work - GetParentMsgFolder won't return an error if the folder has no parent.

Comment 9

[Serge Gautherie (:sgautherie)]

(In reply to comment #8)
> (From update of attachment 321845 [details] [diff] [review])
> I don't think this will work - GetParentMsgFolder won't return an error if the
> folder has no parent.

Then, should the test in <nsLocalMailFolder.cpp> be changed/sync'ed the other way ?

<http://mxr.mozilla.org/seamonkey/search?string=GetParentMsgFolder&case=on&tree=seamonkey>
show it is (one of) the only place where the parameter value is not null checked after the call.