bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Add unit tests for the suggestions

RESOLVED WONTFIX

Status

Firefox OS
Gaia::Keyboard
RESOLVED WONTFIX
5 years ago
5 years ago

People

(Reporter: janjongboom, Assigned: janjongboom)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We don't have any test coverage for the suggestions part of latin.js. Let's do that.
Created attachment 768282 [details] [diff] [review]
Pointer to pull request

This adds some structure to the keyboard suggestions where we can add some more tests in the future. It mocks the worker and has a simple interface to talk to the IM.

The extra lines in latin.js are there because we had an undefined global hanging around that we crashed upon in tests.
Assignee: nobody → janjongboom
Attachment #768282 - Flags: review?(rlu)
Also added a test file for the workers, didn't write any useful tests, but please use it as a framework for building upon.
(Assignee)

Updated

5 years ago
Attachment #768282 - Flags: review?(rlu) → review?(dflanagan)
Jan,

Thanks for these test cases. I won't have time to review before my vacation, however. I'll be back on 7/19.  Feel free to reassign the review if you'd like to get this landed before then.
(Assignee)

Updated

5 years ago
Attachment #768282 - Flags: review?(dflanagan) → review?(rlu)
Superseeded by bug 803189.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.