Display better messages when errors come from other contexts

RESOLVED FIXED in mozilla25

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Irving, Assigned: Irving)

Tracking

unspecified
mozilla25
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 768296 [details] [diff] [review]
Avoid instanceof check for Error object

In testing/xpcshell/head.js we display detailed information about caught errors, based on an "instanceof Error" check. This fails if the error came from a different JS context.

Here's a quick patch that uses duck typing instead of instanceof to get details from errors.
Attachment #768296 - Flags: review?(ted)
Attachment #768296 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/aa7e63e100ae
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Blocks: 890555

Updated

5 years ago
Depends on: 890677
You need to log in before you can comment on or make changes to this bug.