887800 - "(More…)" link from app description does not work

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[Iulian Timis]

Steps to reproduce:
1. Load details page for an app with a big description (ex. https://marketplace.allizom.org/app/evernote-web )
2. Click the (More…) link from the app description section.

Expected results:
More of the app description is displayed.

Actual results:
The "more.." link does not work and all the description is displayed when the app details page is loaded.

Notes/Issues:
Verified on FF25 (Win 7). Issue is reproducing on Stage and -dev. On Production the link is not displayed at all.
Screencast for this issue http://screencast.com/t/bcpgIV4dQ

Comment 1

[Matt Basta [:basta]]

Two things need to be done:
1. Hide the button on widescreen
2. On mobile, set the height of the description box with a nice bottom gradient to a reasonable number of EMs and make the button clear those styles

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Basta, I'm glad you're cc'd on these now ;)

Comment 3

[Matt Basta [:basta]]

Iulian is my man and CCs me on his consumer bugs :)

Comment 4

[Christopher Van Wiemeersch [:cvan]]

Basta, what do you think of just removing it completely (for now)? And ask UX later?

Comment 5

[Matt Basta [:basta]]

That's going to be a really crappy experience if there's a long description.

Comment 6

[Mathieu Pillard [:mat]]

Proposal following basta's suggestion in comment 1 : https://github.com/mozilla/fireplace/pull/209

Comment 7

[Mathieu Pillard [:mat]]

This was fixed in https://github.com/mozilla/fireplace/commit/65efceb18c25accffec3afaa1c799e66791a1132 and https://github.com/mozilla/fireplace/commit/9c8de13e5b99094f1be641ae1f8d20a7d003fdd2

Steps to reproduce:
- Look at an app with a long description [1] on mobile (or small browser window) on -dev, it should be truncated with a nice gradient
- Check that togging more/less to show/hide the full description works correctly
- Check that the toggling link is hidden on widescreen and that the description is not truncated with a gradient on widescreen

- Look at an app with a short description [2]. Check that on both mobile and widescreen the gradient and and the "(more...)" link are hidden.

[1] https://marketplace-dev.allizom.org/app/soundcloud
[2] https://marketplace-dev.allizom.org/app/twitter

Comment 8

[Iulian Timis]

Verified as fixed on https://marketplace-dev.allizom.org/ in FF25 (Win 7) and MP-dev app (Unagi).
The "(more...)" link is not displayed for apps with short description and on desktop, and working properly for apps with long description on mobile.
Closing bug.