webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners.

RESOLVED FIXED in Firefox 25

Status

defect
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: ochameau, Assigned: ochameau)

Tracking

unspecified
Firefox 25
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Assignee

Description

6 years ago
While working on 817580, I realized that we weren't nullifying this.consoleProgressListener during stopListeners request.
It ends up preventing reusing webconsole actor more than once.
(it will duplicate most console message on each new console actor instance)

Patch coming.
Assignee

Updated

6 years ago
Attachment #768309 - Flags: review?(mihai.sucan)
Comment on attachment 768309 [details] [diff] [review]
b2g18 - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners

Thanks for the bug report and for the patch! Good find!

LocationChange tracking has been removed in Firefox 20, in bug 792062.

I think you can just add one liner:

  this.consoleProgressListener = null;

in the case for FileActivity.
Attachment #768309 - Flags: review?(mihai.sucan)
Assignee

Comment 3

6 years ago
Actually I'm targeting gecko18 branch.
I still dream to uplift to 18, but I also want to use same actors fixes for the simulator, which uses gecko18 branch...
Assignee

Updated

6 years ago
Attachment #768309 - Attachment description: webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners → b2g18 - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners
Assignee

Comment 5

6 years ago
Comment on attachment 768409 [details] [diff] [review]
master - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners

I don't know how to manage the 18 story,
so here is a patch for master.
Attachment #768409 - Attachment description: webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners → master - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners
Attachment #768409 - Flags: review?(mihai.sucan)
Comment on attachment 768409 [details] [diff] [review]
master - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners

Thanks!
Attachment #768409 - Flags: review?(mihai.sucan) → review+
Is this patch important for b2g18?
Assignee

Comment 8

6 years ago
It is important mainly if we want to land remote app actors also on 18.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5ba0760ec608
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Assignee

Updated

6 years ago
Attachment #768309 - Attachment is obsolete: true
Assignee

Comment 12

6 years ago
Comment on attachment 771315 [details] [diff] [review]
b2g-18 - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners

Rebased patch for b2g18.
Attachment #771315 - Attachment description: webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners → b2g-18 - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners

Updated

a year ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.