887814 - Bootstrap fails to install clang on macports

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: log

Comment 1

[Gregory Szorc [:gps]]

I just updated macports and it appears mp-clang is no longer a package name. I'm guessing it was removed in the last few months? clang-3.2 and clang-3.3 are valid package names, however.

Patch should be trivial.

Comment 2

[Gregory Szorc [:gps]]

Attachment: Don't use mp-clang in MacPorts bootstrapper

Since you can reproduce this, I'm delegating review power to you.

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 768478 [details] [diff] [review]
Don't use mp-clang in MacPorts bootstrapper

Review of attachment 768478 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me but rebooting to my 10.7 partition is going to take a bit of my time so I'd rather not test this ATM. I imagine landing this wont make it worse but let me know if you want me to test it first.

For the record 10.7 is useful since Valgrind doesn't support 10.8 yet.

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aeb89583349d

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/aeb89583349d

Comment 6

[Jonathan Watt [:jwatt]]

This change broke bootstrap.py for me and at least one other person. See bug 878607.

Comment 7

[Arthur Edelstein [:arthur]]

I also see the breakage reported by :jwatt. I believe this change was incorrect and should be reverted. The MacPorts package name is clang-2.3, but it is installed as mp-clang-2.3 to avoid overwriting existing copies of clang (see http://trac.macports.org/ticket/29171). As osx.py is using MacPorts, we should be using the MacPort-installed mp-clang-2.3.

Comment 8

[Gregory Szorc [:gps]]

(In reply to Arthur Edelstein from comment #7)
> I also see the breakage reported by :jwatt. I believe this change was
> incorrect and should be reverted. The MacPorts package name is clang-2.3,
> but it is installed as mp-clang-2.3 to avoid overwriting existing copies of
> clang (see http://trac.macports.org/ticket/29171). As osx.py is using
> MacPorts, we should be using the MacPort-installed mp-clang-2.3.

Can you please add your findings to bug 878607?