887815 - [SMS][MMS] receiving successful delivery report even though delivery report is OFF in settings

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[ayman maat :maat]

receiving successful delivery report even though delivery report is OFF in settings

**PATH**
1) open message app
2) select new message
3) enter valid phone number into 'to field'
4) enter some text into the message field
 
**EXPECTED**
Message will be successfully delivered without notification

**ACTUAL**
Notification is given in the message thread that the message has been successfully delivered

Comment 1

[ayman maat :maat]

N.B. ensuer that delivery report is OFF in settings before executing steps 1 to 4

build information:

V1-train
Gecko - 914243b
Gaia - 477e572
build id - 20130627123702

Comment 2

[ayman maat :maat]

Attachment: HTML5_SMS-MMSAbbreviatedFlow_20130628_Bug887815__V0.1

reference comment 0 and comment 1

Comment 3

[Julien Wajsberg [:julienw]]

I _think_ we have that bug already.

gene, I think you know ?

Comment 4

[Julien Wajsberg [:julienw]]

we should not do anything in gaia here, only gecko should not send the delivery report.

Comment 5

[Gene Lian (I already quit Mozilla)]

(In reply to Julien Wajsberg [:julienw] from comment #4)
> we should not do anything in gaia here, only gecko should not send the
> delivery report.

Indeed. There might be something wrong in the Gecko. I'll check it out. There should be nothing to do with the Gaia.

Comment 6

[Gene Lian (I already quit Mozilla)]

This one should have been fixed after Bug 884969 and Bug 883095 landed. I'll double check with the latest b2g18 codes and come back with the results.

Comment 7

[Julien Wajsberg [:julienw]]

bug 883095 was uplifted the same day as this bug was reported, so probably it's a dupe.

Comment 8

[Gene Lian (I already quit Mozilla)]

I found out this still doesn't work during the very first time of usage. The settings shows delivery report is off but we'll still receive the delivery report. After toggling the settings to true or false, we can receive delivery report as expected.

This is supposed to be a simple fix on the Gaia end during initialization. I can help with that.

Comment 9

[Gene Lian (I already quit Mozilla)]

Hi dietrich,

The delivery report mechanism is still not yet complete. Need your help to mark this as leo+. Btw, one question, what's the desired delivery report by default? On or off?

I think it should be on. Right? Visible feature is supposed to be better.

Comment 10

[Steve Chung [:steveck]]

Hi Beatriz, Could you confirm the default value for delivery report? Thanks

Comment 11

[Gene Lian (I already quit Mozilla)]

It seems bug 884906 has already had a solution for this.

Comment 12

[Noemí Freire (:noemi)]

(In reply to Steve Chung from comment #10)
> Hi Beatriz, Could you confirm the default value for delivery report? Thanks

The default value for delivery report should be Off. Thanks.

Comment 13

[Gene Lian (I already quit Mozilla)]

OK. So we need to uplift Bug 875854 to b2g18 to fix this issue.

Comment 14

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

If the ril.sms.requestStatusReport.enabled is not available, consider it as false by default.

Comment 15

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 768837 [details] [diff] [review]
Patch

Review of attachment 768837 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 16

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/projects/birch/rev/12982b75bf28

Comment 17

[Gene Lian (I already quit Mozilla)]

Waiting on leo+ to land this to b2g18.

Comment 18

[Gene Lian (I already quit Mozilla)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/8d883cb49438

Comment 19

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/12982b75bf28

Comment 20

[Ryan VanderMeulen [:RyanVM]]

So b2g18 has had busted Marionette testing since Friday due to this landing. What part of "if you push to b2g18, you must watch your push" isn't clear? Backed out.
https://hg.mozilla.org/releases/mozilla-b2g18/rev/004e9cec737f

https://tbpl.mozilla.org/php/getParsedLog.php?id=24705282&tree=Mozilla-B2g18

Comment 21

[Gene Lian (I already quit Mozilla)]

So sorry about this... I'm over-confident with this fix. I'll watch out next time.

Comment 22

[Gene Lian (I already quit Mozilla)]

Attachment: [b2g18] Patch

Comment 23

[Gene Lian (I already quit Mozilla)]

Reland: https://hg.mozilla.org/releases/mozilla-b2g18/rev/15923aca6e6d

Comment 24

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/15923aca6e6d

Comment 25

[isabelrios]

Verified with unagi 07/03 v1-train build:
Gecko-109f9e3
Gaia-2c40cce

When delivery report is off, the double check does not appear next to the message sent.