GCC compilation failure in RadialGradientEffectD2D1.cpp

RESOLVED FIXED in mozilla25

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jacek, Assigned: jacek)

Tracking

unspecified
mozilla25
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 768322 [details] [diff] [review]
fix

I get series of errors in my mingw builds:

RadialGradientEffectD2D1.cpp:267:49: error: ISO C++ forbids taking the address of a bound member function to form a pointer to member function.  Say ‘&mozilla::gfx::RadialGradientEffectD2D1::SetStopCollection’ [-fpermissive]

The attached patch fixes the problem and, while I was at this, adds MOZ_FINAL to RadialGradientEffectD2D1 to avoid another warning.
Attachment #768322 - Flags: review?(jmuizelaar)
Attachment #768322 - Flags: review?(jmuizelaar) → review+
Bas, you'll want to land this in the moz2d
(Assignee)

Comment 2

5 years ago
Thanks for review. I'm not sure what's involved in moz2d landing, AFAICS its separated repo is still empty and other bugs land directly to m-i, so that's what I did:

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b86302ab2b3
https://hg.mozilla.org/mozilla-central/rev/7b86302ab2b3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.