Closed Bug 887828 Opened 7 years ago Closed 7 years ago

GCC compilation failure in SkThread_win.cpp

Categories

(Core :: Graphics, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: jacek, Assigned: jacek)

Details

Attachments

(1 file)

I get following error:

SkThread_win.cpp:39:61: error: invalid static_cast from type ‘int32_t {aka int}’ to type ‘const volatile LONG& {aka const volatile long int&}’

It's already fixed upstream:
https://code.google.com/p/skia/source/detail?r=9706#

See:
https://codereview.chromium.org/17047004/
for details.

I will attach a backport to mozilla tree.
Attached patch fix backportSplinter Review
Attachment #768332 - Flags: review?
Attachment #768332 - Flags: review? → review?(gwright)
Comment on attachment 768332 [details] [diff] [review]
fix backport

Patch file isn't needed really as the fix is present upstream.
Attachment #768332 - Flags: review?(gwright) → review+
OK, pushed without the patch file, thanks.

https://hg.mozilla.org/integration/mozilla-inbound/rev/1651ea86cb00
https://hg.mozilla.org/mozilla-central/rev/1651ea86cb00
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.