88790 - Build config uses wrong architecture (-xarch=...)

Status: VERIFIED INVALID

(SeaMonkey :: Build Config, defect)

Description

[Roland Mainz]

[spin-off of bug 20860]
Build config seems to use -xarch=v8 in two cases where it is not wanted:
1. I want to build a clean sparcv7 binary... no v8 extensions (SuperSPARC etc.)
2. I want to build a sparcv9 binary, e.g. 64bit SPARC

Looking at js/src/Makefile from my sparcv9 build (see bug 20860):
-- snip --
% cat js/src/Makefile | fgrep "xarch"
ULTRA_OPTIONS   := -xarch=v8plus,-DULTRA_SPARC
ULTRA_OPTIONS   := -xarch=v8
ASFLAGS         += -Wa,-xarch=v8,-P,-L,-D_ASM,-D__STDC__=0
-- snip --
This should never be "v8" for two reasons:
1. Sun Workshop is explicitly running in 64bit mode (export
CC="/opt/SUNWspro/bin/cc -xarch=v9" CXX="/opt/SUNWspro/bin/CC -xarch=v9")
2. Without [1] it should default to v7 unless someone turns v8 extensions
explicitly "on"...

Comment 1

[cls]

All uses of -xarch=v8 are inside an ifdef.  I'm not sure if that ifdef is even being used anymore as we have the --enable-ultrasparc option which does the same thing (sorta).

Comment 2

[Roland Mainz]

1. thanks for the hint with ASFLAGS... I'll try it once scc fixed the string
stuff
2. It may be usefull to replace --enable-ultrasparc with something more generic
like --use-sparc-xarch=xxx where xxx is one of {v7,v8,v8a,v8b,v9,v9a,v9b,...} -
e.g. the "xxx" value gets feed to CC/CXX/AS - default should be "v7" (generic
SPARC)...

Comment 3

[cls]

I don't like that idea at all.  Adding a --use-sparc-xarch= implies a level of
support for solaris CC nuances that really isn't there.  Also, there's no reason
for those values to be hardcoded within the Mozilla build system.  The same
effect can be accomplished by setting CC,CXX & ASFLAGS appropriately. 

I don't see any evidence of -xarch=v8 creeping into the build when it should
not.  Marking invalid.

Comment 4

[Jon Granrose]

verified invalid.