887903 - Use fallible nsDeque::Push in the cycle collector

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

See patch 3 in bug 875304.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: non-fatal assertion and telemetry for OOM during nsDeque push

This keeps happening on tbpl, so we should at least make it nicer.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 783854 [details] [diff] [review]
non-fatal assertion and telemetry for OOM during nsDeque push

+    void Failed() {
{ to the next line

I'd prefer use of Type* aFoo style for * and & but the file
isn't consistent so don't care too much.

Comment 3

[Andrew McCreight [:mccr8]]

I fixed the brace, but not the pointer stuff, because that was the style being used near those bits of code.

https://hg.mozilla.org/integration/mozilla-inbound/rev/9dfe8e0a88cc

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9dfe8e0a88cc